From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C330C77B78 for ; Thu, 20 Apr 2023 08:09:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234339AbjDTIJQ (ORCPT ); Thu, 20 Apr 2023 04:09:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44156 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234337AbjDTIJN (ORCPT ); Thu, 20 Apr 2023 04:09:13 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C1DF9FC; Thu, 20 Apr 2023 01:09:08 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2746C645AB; Thu, 20 Apr 2023 08:09:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 911D1C433EF; Thu, 20 Apr 2023 08:09:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1681978147; bh=ImzOYmQ4yUAimeoREYTG/Ic4X9E0mCDibkc7vPhya5g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Gm2KDvefKPiwYxUSqqIQl5ioJOzO0AcVRlCaKwSP1rY1ZyadRI8dF/Ce3WkKJQRSs Sc5BXlTLKFHYQwrzFGZOKgV2aR12u/kZ4Dw9hUXt8WZ8IAZh+a33VypEYXIwETMJT4 RtiSofNBctrEcmE2qu2FroRvVRTLpqw8hK4BzQmQ= Date: Thu, 20 Apr 2023 10:08:59 +0200 From: Greg KH To: Heikki Krogerus Cc: Frank Wang , linux@roeck-us.net, heiko@sntech.de, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, huangtao@rock-chips.com, william.wu@rock-chips.com, jianwei.zheng@rock-chips.com, yubing.zhang@rock-chips.com, wmc@rock-chips.com Subject: Re: [PATCH v2] usb: typec: tcpm: fix multiple times discover svids error Message-ID: References: <20230316081149.24519-1-frank.wang@rock-chips.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Fri, Mar 17, 2023 at 01:27:13PM +0200, Heikki Krogerus wrote: > On Thu, Mar 16, 2023 at 04:11:49PM +0800, Frank Wang wrote: > > PD3.0 Spec 6.4.4.3.2 say that only Responder supports 12 or more SVIDs, > > the Discover SVIDs Command Shall be executed multiple times until a > > Discover SVIDs VDO is returned ending either with a SVID value of > > 0x0000 in the last part of the last VDO or with a VDO containing two > > SVIDs with values of 0x0000. > > > > In the current implementation, if the last VDO does not find that the > > Discover SVIDs Command would be executed multiple times even if the > > Responder SVIDs are less than 12, and we found some odd dockers just > > meet this case. So fix it. > > > > Signed-off-by: Frank Wang > > --- > > drivers/usb/typec/tcpm/tcpm.c | 16 +++++++++++++++- > > 1 file changed, 15 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c > > index 66de02a56f512..a3ae2c79f3540 100644 > > --- a/drivers/usb/typec/tcpm/tcpm.c > > +++ b/drivers/usb/typec/tcpm/tcpm.c > > @@ -1515,7 +1515,21 @@ static bool svdm_consume_svids(struct tcpm_port *port, const u32 *p, int cnt) > > pmdata->svids[pmdata->nsvids++] = svid; > > tcpm_log(port, "SVID %d: 0x%x", pmdata->nsvids, svid); > > } > > - return true; > > + > > + /* > > + * PD3.0 Spec 6.4.4.3.2: The SVIDs are returned 2 per VDO (see Table > > + * 6-43), and can be returned maximum 6 VDOs per response (see Figure > > + * 6-19). If the Respondersupports 12 or more SVID then the Discover > > + * SVIDs Command Shall be executed multiple times until a Discover > > + * SVIDs VDO is returned ending either with a SVID value of 0x0000 in > > + * the last part of the last VDO or with a VDO containing two SVIDs > > + * with values of 0x0000. > > + * > > + * However, some odd dockers support SVIDs less than 12 but without > > + * 0x0000 in the last VDO, so we need to break the Discover SVIDs > > + * request and return false here. > > + */ > > + return cnt == 7; > > abort: > > tcpm_log(port, "SVID_DISCOVERY_MAX(%d) too low!", SVID_DISCOVERY_MAX); > > return false; > > This is OK by men, but let's wait for Guenter. What ever happened to this patch? thanks, greg k-h