From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Suhui <suhui@nfschina.com>
Cc: Guenter Roeck <linux@roeck-us.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] usb: typec: tcpm: remove unnecessary (void*) conversions
Date: Mon, 24 Apr 2023 16:03:21 +0300 [thread overview]
Message-ID: <ZEZ+GUsvaqWg6A3W@kuha.fi.intel.com> (raw)
In-Reply-To: <20230424041940.132866-1-suhui@nfschina.com>
On Mon, Apr 24, 2023 at 12:19:40PM +0800, Suhui wrote:
> No need cast (void*) to (struct fusb302_chip *) or (struct tcpm_port *).
>
> Signed-off-by: Suhui <suhui@nfschina.com>
Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> drivers/usb/typec/tcpm/fusb302.c | 2 +-
> drivers/usb/typec/tcpm/tcpm.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/typec/tcpm/fusb302.c b/drivers/usb/typec/tcpm/fusb302.c
> index 1ffce00d94b4..4b7b8f6af3ca 100644
> --- a/drivers/usb/typec/tcpm/fusb302.c
> +++ b/drivers/usb/typec/tcpm/fusb302.c
> @@ -190,7 +190,7 @@ static void fusb302_log(struct fusb302_chip *chip, const char *fmt, ...)
>
> static int fusb302_debug_show(struct seq_file *s, void *v)
> {
> - struct fusb302_chip *chip = (struct fusb302_chip *)s->private;
> + struct fusb302_chip *chip = s->private;
> int tail;
>
> mutex_lock(&chip->logbuffer_lock);
> diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c
> index 1ee774c263f0..ab3a54662ed9 100644
> --- a/drivers/usb/typec/tcpm/tcpm.c
> +++ b/drivers/usb/typec/tcpm/tcpm.c
> @@ -737,7 +737,7 @@ static void tcpm_log_source_caps(struct tcpm_port *port)
>
> static int tcpm_debug_show(struct seq_file *s, void *v)
> {
> - struct tcpm_port *port = (struct tcpm_port *)s->private;
> + struct tcpm_port *port = s->private;
> int tail;
>
> mutex_lock(&port->logbuffer_lock);
> --
> 2.30.2
--
heikki
next prev parent reply other threads:[~2023-04-24 13:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-24 4:19 [PATCH] usb: typec: tcpm: remove unnecessary (void*) conversions Suhui
2023-04-24 13:03 ` Heikki Krogerus [this message]
2023-05-08 14:55 ` Greg Kroah-Hartman
2023-05-09 2:14 ` Su Hui
-- strict thread matches above, loose matches on Subject: below --
2023-03-16 8:23 Yu Zhe
2023-03-17 11:29 ` Heikki Krogerus
2023-03-17 12:18 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZEZ+GUsvaqWg6A3W@kuha.fi.intel.com \
--to=heikki.krogerus@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=suhui@nfschina.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox