From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D54B4C77B61 for ; Tue, 25 Apr 2023 13:04:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233454AbjDYNEj (ORCPT ); Tue, 25 Apr 2023 09:04:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37402 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233896AbjDYNEg (ORCPT ); Tue, 25 Apr 2023 09:04:36 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 36D2DBB9D for ; Tue, 25 Apr 2023 06:04:33 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C66BA6184B for ; Tue, 25 Apr 2023 13:04:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B2954C433D2; Tue, 25 Apr 2023 13:04:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1682427872; bh=WflIEZ0tToKfhYMzvsdh1SIlg7Xvtd3NacJSsiTX/kU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Uy9z2VcsSjAU8UDu6jy3VrFAdYCOtctoToiOgt1ZwZTGqh76fhBSKpHK1qoo+/t/X EeAftZx0ndbjrXB883aDeEBqnIzFfdhxJa4BefuL8Ey+T22KBZ+m6SEynWMrzj/LtP dioOHq77ldH5ZU7dTttA+Q0eufYwC18fOklQMUMs= Date: Tue, 25 Apr 2023 15:04:28 +0200 From: Greg KH To: Konrad =?iso-8859-1?Q?Gr=E4fe?= Cc: linux-usb@vger.kernel.org Subject: Re: [PATCH] usb: gadget: u_ether: Fix host MAC address case Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Tue, Apr 25, 2023 at 02:58:53PM +0200, Konrad Gräfe wrote: > > As the CDC-ECM specification states the host MAC address must be sent to > the host as an uppercase hexadecimal string: > The Unicode character is chosen from the set of values 30h through > 39h and 41h through 46h (0-9 and A-F). > > However, snprintf(.., "%pm", ..) generates a lowercase MAC address > string. While most host drivers are tolerant to this, UsbNcm.sys on > Windows 10 is not. Instead it uses a different MAC address with all > bytes set to zero including and after the first byte containing a > lowercase letter. On Windows 11 Microsoft fixed it, but apparently they > did not backport the fix. > > This change fixes the issue by upper-casing the MAC to comply with the > specification. > > Signed-off-by: Konrad Gräfe > --- > drivers/usb/gadget/function/u_ether.c | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > > diff --git drivers/usb/gadget/function/u_ether.c drivers/usb/gadget/function/u_ether.c > index 6956ad8ba8dd..49d29b04ef93 100644 > --- drivers/usb/gadget/function/u_ether.c > +++ drivers/usb/gadget/function/u_ether.c > @@ -958,6 +958,7 @@ EXPORT_SYMBOL_GPL(gether_get_host_addr); > int gether_get_host_addr_cdc(struct net_device *net, char *host_addr, int len) > { > struct eth_dev *dev; > + int i, slen; > > if (len < 13) > return -EINVAL; > @@ -965,7 +966,14 @@ int gether_get_host_addr_cdc(struct net_device *net, char *host_addr, int len) > dev = netdev_priv(net); > snprintf(host_addr, len, "%pm", dev->host_mac); > > - return strlen(host_addr); > + > + slen = strlen(host_addr); > + > + for(i = 0; i < slen; i++) { > + host_addr[i] = toupper(host_addr[i]); > + } > + > + return slen; > } > EXPORT_SYMBOL_GPL(gether_get_host_addr_cdc); > > Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - Your patch contains warnings and/or errors noticed by the scripts/checkpatch.pl tool. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot