From: Johan Hovold <johan@kernel.org>
To: Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
Udipto Goswami <quic_ugoswami@quicinc.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Pratham Pratap <quic_ppratap@quicinc.com>,
Jack Pham <quic_jackp@quicinc.com>,
Johan Hovold <johan+linaro@kernel.org>,
Oliver Neukum <oneukum@suse.com>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH v9] usb: dwc3: debugfs: Prevent any register access when devices is runtime suspended
Date: Mon, 8 May 2023 13:34:22 +0200 [thread overview]
Message-ID: <ZFjePu8Wb6NUwCav@hovoldconsulting.com> (raw)
In-Reply-To: <20230506013036.j533xncixkky5uf6@synopsys.com>
On Sat, May 06, 2023 at 01:30:52AM +0000, Thinh Nguyen wrote:
Udipto, looks like you just ignored my comment about fixing up the patch
Subject.
> On Fri, May 05, 2023, Udipto Goswami wrote:
> > When the dwc3 device is runtime suspended, various required clocks would
> > get disabled and it is not guaranteed that access to any registers would
> > work. Depending on the SoC glue, a register read could be as benign as
> > returning 0 or be fatal enough to hang the system.
> >
> > In order to prevent such scenarios of fatal errors, make sure to resume
> > dwc3 then allow the function to proceed.
> >
> > Fixes: 62ba09d6bb63 ("usb: dwc3: debugfs: Dump internal LSP and ep registers")
>
> This fix goes before the above change.
Yes, this clearly is not the commit that first introduced this issue.
Either add a Fixes tag for the oldest one or add one for each commit
that introduced debugfs attributes with this issues.
> This also touches on many places and is more than 100 lines. While this
> is a fix, I'm not sure if Cc stable is needed. Perhaps others can
> comment.
I believe this should be backported as it fixes a crash/hang.
The stable rules are flexible, but it may also be possible to break the
patch up in pieces and add a corresponding Fixes tag.
Johan
next prev parent reply other threads:[~2023-05-08 11:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-05 15:51 [PATCH v9] usb: dwc3: debugfs: Prevent any register access when devices is runtime suspended Udipto Goswami
2023-05-06 1:30 ` Thinh Nguyen
2023-05-08 11:34 ` Johan Hovold [this message]
2023-05-08 15:48 ` Udipto Goswami
2023-05-09 6:30 ` Johan Hovold
2023-05-08 22:26 ` Thinh Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZFjePu8Wb6NUwCav@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=Thinh.Nguyen@synopsys.com \
--cc=gregkh@linuxfoundation.org \
--cc=johan+linaro@kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=oneukum@suse.com \
--cc=quic_jackp@quicinc.com \
--cc=quic_ppratap@quicinc.com \
--cc=quic_ugoswami@quicinc.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox