From: Johan Hovold <johan@kernel.org>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: oe-kbuild@lists.linux.dev,
Udipto Goswami <quic_ugoswami@quicinc.com>,
Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
lkp@intel.com, oe-kbuild-all@lists.linux.dev,
Pratham Pratap <quic_ppratap@quicinc.com>,
Jack Pham <quic_jackp@quicinc.com>,
Johan Hovold <johan+linaro@kernel.org>,
Oliver Neukum <oneukum@suse.com>,
linux-usb@vger.kernel.org
Subject: Re: [PATCH v8] usb: dwc3: debugfs: Prevent any register access when devices is runtime suspended
Date: Wed, 10 May 2023 09:50:48 +0200 [thread overview]
Message-ID: <ZFtM2NKsj7Md9jFC@hovoldconsulting.com> (raw)
In-Reply-To: <df7bd9f8-f327-42cb-a5d4-42a804b9790d@kili.mountain>
On Wed, May 10, 2023 at 10:32:54AM +0300, Dan Carpenter wrote:
> Hi Udipto,
>
> kernel test robot noticed the following build warnings:
>
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
>
> url: https://github.com/intel-lab-lkp/linux/commits/Udipto-Goswami/usb-dwc3-debugfs-Prevent-any-register-access-when-devices-is-runtime-suspended/20230504-125225
> base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
> patch link: https://lore.kernel.org/r/20230504045052.22347-1-quic_ugoswami%40quicinc.com
> patch subject: [PATCH v8] usb: dwc3: debugfs: Prevent any register access when devices is runtime suspended
> config: x86_64-randconfig-m001 (https://download.01.org/0day-ci/archive/20230510/202305101451.V2D0cM4S-lkp@intel.com/config)
> compiler: gcc-11 (Debian 11.3.0-12) 11.3.0
>
> If you fix the issue, kindly add following tag where applicable
> | Reported-by: kernel test robot <lkp@intel.com>
> | Reported-by: Dan Carpenter <error27@gmail.com>
> | Link: https://lore.kernel.org/r/202305101451.V2D0cM4S-lkp@intel.com/
>
> New smatch warnings:
> drivers/usb/dwc3/debugfs.c:647 dwc3_link_state_write() warn: missing error code? 'ret'
> drivers/usb/dwc3/debugfs.c:720 dwc3_rx_fifo_size_show() warn: curly braces intended?
> drivers/usb/dwc3/debugfs.c:722 dwc3_rx_fifo_size_show() warn: inconsistent indenting
> drivers/usb/dwc3/debugfs.c:722 dwc3_rx_fifo_size_show() warn: ignoring unreachable code.
>
> Old smatch warnings:
> drivers/usb/dwc3/debugfs.c:657 dwc3_link_state_write() warn: missing error code? 'ret'
>
> vim +/ret +647 drivers/usb/dwc3/debugfs.c
>
> 1c53edaeee3338 Udipto Goswami 2023-05-04 638 ret = pm_runtime_resume_and_get(dwc->dev);
> 1c53edaeee3338 Udipto Goswami 2023-05-04 639 if (ret < 0)
> 1c53edaeee3338 Udipto Goswami 2023-05-04 640 return ret;
> 1c53edaeee3338 Udipto Goswami 2023-05-04 641
> 138801aaa566ec Felipe Balbi 2012-01-02 642 spin_lock_irqsave(&dwc->lock, flags);
> d102444cac1564 Thinh Nguyen 2018-11-07 643 reg = dwc3_readl(dwc->regs, DWC3_GSTS);
> d102444cac1564 Thinh Nguyen 2018-11-07 644 if (DWC3_GSTS_CURMOD(reg) != DWC3_GSTS_CURMOD_DEVICE) {
> d102444cac1564 Thinh Nguyen 2018-11-07 645 spin_unlock_irqrestore(&dwc->lock, flags);
> 1c53edaeee3338 Udipto Goswami 2023-05-04 646 pm_runtime_put_sync(dwc->dev);
> 1c53edaeee3338 Udipto Goswami 2023-05-04 @647 return ret;
>
> ret is not necessarily an error code.
>
> d102444cac1564 Thinh Nguyen 2018-11-07 648 }
> d102444cac1564 Thinh Nguyen 2018-11-07 649
> 0d36dede457873 Thinh Nguyen 2018-11-07 650 reg = dwc3_readl(dwc->regs, DWC3_DSTS);
> 0d36dede457873 Thinh Nguyen 2018-11-07 651 speed = reg & DWC3_DSTS_CONNECTSPD;
> 0d36dede457873 Thinh Nguyen 2018-11-07 652
> 0d36dede457873 Thinh Nguyen 2018-11-07 653 if (speed < DWC3_DSTS_SUPERSPEED &&
> 0d36dede457873 Thinh Nguyen 2018-11-07 654 state != DWC3_LINK_STATE_RECOV) {
> 0d36dede457873 Thinh Nguyen 2018-11-07 655 spin_unlock_irqrestore(&dwc->lock, flags);
> 1c53edaeee3338 Udipto Goswami 2023-05-04 656 pm_runtime_put_sync(dwc->dev);
> 1c53edaeee3338 Udipto Goswami 2023-05-04 657 return ret;
> 0d36dede457873 Thinh Nguyen 2018-11-07 658 }
>
> [ snip ]
>
> 2c85a1817e4ba0 Thinh Nguyen 2018-11-07 708 static int dwc3_rx_fifo_size_show(struct seq_file *s, void *unused)
> 818ec3aba883f5 Felipe Balbi 2016-04-14 709 {
> 818ec3aba883f5 Felipe Balbi 2016-04-14 710 struct dwc3_ep *dep = s->private;
> 818ec3aba883f5 Felipe Balbi 2016-04-14 711 struct dwc3 *dwc = dep->dwc;
> 818ec3aba883f5 Felipe Balbi 2016-04-14 712 unsigned long flags;
> d00be779cc5016 Thinh Nguyen 2021-03-27 713 u32 mdwidth;
> 818ec3aba883f5 Felipe Balbi 2016-04-14 714 u32 val;
> 1c53edaeee3338 Udipto Goswami 2023-05-04 715 int ret;
> 1c53edaeee3338 Udipto Goswami 2023-05-04 716
> 1c53edaeee3338 Udipto Goswami 2023-05-04 717 ret = pm_runtime_resume_and_get(dwc->dev);
> 1c53edaeee3338 Udipto Goswami 2023-05-04 718 if (ret < 0)
> 1c53edaeee3338 Udipto Goswami 2023-05-04 719 pm_runtime_put_sync(dwc->dev);
> 1c53edaeee3338 Udipto Goswami 2023-05-04 @720 return ret;
>
> Needs curly braces.
I believe this was all fixed in v9/v10.
Johan
prev parent reply other threads:[~2023-05-10 7:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-04 4:50 [PATCH v8] usb: dwc3: debugfs: Prevent any register access when devices is runtime suspended Udipto Goswami
2023-05-04 7:28 ` kernel test robot
2023-05-04 8:16 ` Johan Hovold
2023-05-09 22:04 ` kernel test robot
2023-05-10 7:32 ` Dan Carpenter
2023-05-10 7:50 ` Johan Hovold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZFtM2NKsj7Md9jFC@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=Thinh.Nguyen@synopsys.com \
--cc=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=johan+linaro@kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=oe-kbuild@lists.linux.dev \
--cc=oneukum@suse.com \
--cc=quic_jackp@quicinc.com \
--cc=quic_ppratap@quicinc.com \
--cc=quic_ugoswami@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox