From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92C5DC77B75 for ; Fri, 19 May 2023 08:17:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230389AbjESIR4 (ORCPT ); Fri, 19 May 2023 04:17:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52944 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230325AbjESIRm (ORCPT ); Fri, 19 May 2023 04:17:42 -0400 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B051210DC for ; Fri, 19 May 2023 01:17:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1684484255; x=1716020255; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=9fCXL+QfManF/BO6ETnv3SaP6od/vI6ckK+D5YpEYQE=; b=Vmq/9nocFfPdxAGfSB0JS61sIXeRnBUZlt1ygF1mDc9P96Qlj6e1OrOC iqdOyiEkpTnnp/iXatY4sIYP0TyNVRteq2rltBRMTKlbctl6aSZnOHH6W M82+JCwBdWffqnl94HX3to/46WVnX7cLRCLU1nR1amgjgyYBA3K34zByY zkyqjveFmKQjh191M0qn9KVKZNQLt7+dglLE3aXDCY1TLhcSCEqy4dR0K FruprCUMp8v517XqrS2FIki9AuD6YpEG1RMFMyfj9YVk9KyD+4UC5DyJV 8nBSYJk6riUkc8nup4hM70b+49duAlqv+bwAgVLu+oUVwAgIS+po9iQa9 Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10714"; a="341749375" X-IronPort-AV: E=Sophos;i="6.00,176,1681196400"; d="scan'208";a="341749375" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 May 2023 01:17:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10714"; a="846811912" X-IronPort-AV: E=Sophos;i="6.00,176,1681196400"; d="scan'208";a="846811912" Received: from kuha.fi.intel.com ([10.237.72.185]) by fmsmga001.fm.intel.com with SMTP; 19 May 2023 01:17:31 -0700 Received: by kuha.fi.intel.com (sSMTP sendmail emulation); Fri, 19 May 2023 11:17:30 +0300 Date: Fri, 19 May 2023 11:17:30 +0300 From: Heikki Krogerus To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: Guenter Roeck , Greg Kroah-Hartman , Matthias Brugger , AngeloGioacchino Del Regno , linux-usb@vger.kernel.org, kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH 94/97] usb: typec: tcpci_mt6360: Convert to platform remove callback returning void Message-ID: References: <20230517230239.187727-1-u.kleine-koenig@pengutronix.de> <20230517230239.187727-95-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230517230239.187727-95-u.kleine-koenig@pengutronix.de> Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Thu, May 18, 2023 at 01:02:36AM +0200, Uwe Kleine-König wrote: > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is ignored (apart from > emitting a warning) and this typically results in resource leaks. To improve > here there is a quest to make the remove callback return void. In the first > step of this quest all drivers are converted to .remove_new() which already > returns void. Eventually after all drivers are converted, .remove_new() is > renamed to .remove(). > > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > > Signed-off-by: Uwe Kleine-König Acked-by: Heikki Krogerus > --- > drivers/usb/typec/tcpm/tcpci_mt6370.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/usb/typec/tcpm/tcpci_mt6370.c b/drivers/usb/typec/tcpm/tcpci_mt6370.c > index c5bb201a5163..2a079464b398 100644 > --- a/drivers/usb/typec/tcpm/tcpci_mt6370.c > +++ b/drivers/usb/typec/tcpm/tcpci_mt6370.c > @@ -178,12 +178,10 @@ static int mt6370_tcpc_probe(struct platform_device *pdev) > return 0; > } > > -static int mt6370_tcpc_remove(struct platform_device *pdev) > +static void mt6370_tcpc_remove(struct platform_device *pdev) > { > dev_pm_clear_wake_irq(&pdev->dev); > device_init_wakeup(&pdev->dev, false); > - > - return 0; > } > > static const struct of_device_id mt6370_tcpc_devid_table[] = { > @@ -198,7 +196,7 @@ static struct platform_driver mt6370_tcpc_driver = { > .of_match_table = mt6370_tcpc_devid_table, > }, > .probe = mt6370_tcpc_probe, > - .remove = mt6370_tcpc_remove, > + .remove_new = mt6370_tcpc_remove, > }; > module_platform_driver(mt6370_tcpc_driver); > > -- > 2.39.2 -- heikki