linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Corey Minyard <minyard@acm.org>
To: Johan Hovold <johan@kernel.org>
Cc: Craig Shelley <craig@microtron.org.uk>,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	linux-usb@vger.kernel.org
Subject: Re: Break doesn't work on a CP2105
Date: Mon, 22 May 2023 07:52:45 -0500	[thread overview]
Message-ID: <ZGtlnWGSc31Wdhxa@mail.minyard.net> (raw)
In-Reply-To: <ZGtZKCvo71woGf9T@hovoldconsulting.com>

On Mon, May 22, 2023 at 01:59:36PM +0200, Johan Hovold wrote:
> Hi Corey,
> 
> and sorry about the late reply on this.

Not a problem, thanks for replying.

> 
> On Wed, Apr 26, 2023 at 03:04:03PM -0500, Corey Minyard wrote:
> > I have a development board with a CP2105 on it, and I was trying to send
> > a break to it to do a sysrq.  And it wasn't working.
> > 
> > I have verified that the target driver works by setting a really slow
> > baud rate and sending something with a lot of zero bits.  It got breaks
> > just fine.
> > 
> > If I use TCSBRK, it seems to just send a short time with zeros, not
> > even a full character's worth.  It receives a valid character with the
> > top few bits set.  If I use TCSBRKP with a longer time, like 2.5
> > seconds, it waits the whole time, then at the very end it gets the
> > character as with the shorter break.
> > 
> > I can't find a programming manual for the chip, and I'm not sure what's
> > going on.
> 
> I just verified that break works on the first port of my cp2105 but not
> on the second one (I seem to receive the last characters sent instead).
> 
> Apparently this is expected as the datasheet (AN571) says the following
> about the SET_BREAK command:
> 
> 	This command is not supported on the second CP2105 interface.
> 
> Which port are you seeing this behaviour with?

I'm guessing this is it.  From the schematic I think this is the
TXD_ECI pin, though I'm not 100% sure.  I'd have to dig through the
device tree and SOC manual to be sure which port is which.

Would it be possible to return an error in this situation instead of it
silently not working?  Just to avoid others having the same issue.

Thank you,

-corey

  reply	other threads:[~2023-05-22 12:52 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-26 20:04 Break doesn't work on a CP2105 Corey Minyard
2023-04-26 23:42 ` [PATCH] USB: serial: cp210x: work around silicon bug setting break minyard
2023-05-22 11:59 ` Break doesn't work on a CP2105 Johan Hovold
2023-05-22 12:52   ` Corey Minyard [this message]
2023-06-02 12:53     ` Johan Hovold
2023-06-02 16:46       ` Corey Minyard
2023-06-04 12:17         ` Johan Hovold
2023-06-04 20:11           ` Corey Minyard
2023-06-05  7:15             ` Johan Hovold
2023-06-05 12:25               ` Corey Minyard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZGtlnWGSc31Wdhxa@mail.minyard.net \
    --to=minyard@acm.org \
    --cc=craig@microtron.org.uk \
    --cc=johan@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).