* [PATCH] usb: typec: tcpm: Replace the ternary conditional operator with max()
@ 2023-06-26 12:11 You Kangren
2023-06-30 12:48 ` Heikki Krogerus
0 siblings, 1 reply; 2+ messages in thread
From: You Kangren @ 2023-06-26 12:11 UTC (permalink / raw)
To: Guenter Roeck, Heikki Krogerus, Greg Kroah-Hartman,
open list:USB TYPEC PORT CONTROLLER DRIVERS, open list
Cc: opensource.kernel, youkangren
Replace the ternary conditional operator with max() to make the code clean
Signed-off-by: You Kangren <youkangren@vivo.com>
---
drivers/usb/typec/tcpm/tcpm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c
index 829d75ebab42..2a0b33bd2eb8 100644
--- a/drivers/usb/typec/tcpm/tcpm.c
+++ b/drivers/usb/typec/tcpm/tcpm.c
@@ -6353,7 +6353,7 @@ static int tcpm_psy_get_input_power_limit(struct tcpm_port *port,
src_mv = pdo_fixed_voltage(pdo);
src_ma = pdo_max_current(pdo);
tmp = src_mv * src_ma;
- max_src_uw = tmp > max_src_uw ? tmp : max_src_uw;
+ max_src_uw = max(tmp, max_src_uw);
}
}
--
2.39.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] usb: typec: tcpm: Replace the ternary conditional operator with max()
2023-06-26 12:11 [PATCH] usb: typec: tcpm: Replace the ternary conditional operator with max() You Kangren
@ 2023-06-30 12:48 ` Heikki Krogerus
0 siblings, 0 replies; 2+ messages in thread
From: Heikki Krogerus @ 2023-06-30 12:48 UTC (permalink / raw)
To: You Kangren
Cc: Guenter Roeck, Greg Kroah-Hartman,
open list:USB TYPEC PORT CONTROLLER DRIVERS, open list,
opensource.kernel
On Mon, Jun 26, 2023 at 08:11:05PM +0800, You Kangren wrote:
> Replace the ternary conditional operator with max() to make the code clean
>
> Signed-off-by: You Kangren <youkangren@vivo.com>
> ---
> drivers/usb/typec/tcpm/tcpm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c
> index 829d75ebab42..2a0b33bd2eb8 100644
> --- a/drivers/usb/typec/tcpm/tcpm.c
> +++ b/drivers/usb/typec/tcpm/tcpm.c
> @@ -6353,7 +6353,7 @@ static int tcpm_psy_get_input_power_limit(struct tcpm_port *port,
> src_mv = pdo_fixed_voltage(pdo);
> src_ma = pdo_max_current(pdo);
> tmp = src_mv * src_ma;
> - max_src_uw = tmp > max_src_uw ? tmp : max_src_uw;
> + max_src_uw = max(tmp, max_src_uw);
Is that "tmp" useful anymore - why not drop it while at it?
thanks,
--
heikki
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-06-30 12:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-26 12:11 [PATCH] usb: typec: tcpm: Replace the ternary conditional operator with max() You Kangren
2023-06-30 12:48 ` Heikki Krogerus
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).