From: Johan Hovold <johan@kernel.org>
To: Davide Tronchin <davide.tronchin.94@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
marco.demarco@posteo.net
Subject: Re: [PATCH v2] Add LARA-R6 01B PIDs for three different USB compositions.
Date: Thu, 22 Jun 2023 13:51:44 +0200 [thread overview]
Message-ID: <ZJQ10DKDic-FEKM6@hovoldconsulting.com> (raw)
In-Reply-To: <20230622092921.12651-1-davide.tronchin.94@gmail.com>
On Thu, Jun 22, 2023 at 11:29:21AM +0200, Davide Tronchin wrote:
> The new LARA-R6 product variant identified by the "01B" string can be
> configured (by AT interface) in three different USB modes:
> Signed-off-by: Davide Tronchin <davide.tronchin.94@gmail.com>
> ---
>
> V1 -> V2: change from USB_DEVICE() to USB_DEVICE_INTERFACE_CLASS() in
> LARA-R6 01B CDC-ECM USB mode.
> Move LARA-R6 01B PIDs above LARA-L6 0x1341 PID.
> Change commit message to explain better the common USB interfaces.
> Add here in the comments the usb/devices file of the LARA-R6 01B module
> in all the USB configurations.
Thanks for the update.
You forgot the commit summary prefix so I added that and shortened the
summary to make it more succinct:
USB: serial: option: add LARA-R6 01B PIDs
I also reduced the indentation of the product comments which appeared
excessive for the first two entries.
End-result is here:
https://git.kernel.org/pub/scm/linux/kernel/git/johan/usb-serial.git/commit/?h=usb-next&id=ffa5f7a3bf28c1306eef85d4056539c2d4b8eb09
Johan
next prev parent reply other threads:[~2023-06-22 11:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-22 9:29 [PATCH v2] Add LARA-R6 01B PIDs for three different USB compositions Davide Tronchin
2023-06-22 11:51 ` Johan Hovold [this message]
2023-06-22 13:13 ` Davide Tronchin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZJQ10DKDic-FEKM6@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=davide.tronchin.94@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=marco.demarco@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox