Re: [PATCH] USB: serial: simple-serial: spell out the ordering

[Johan Hovold <johan@kernel.org>]

On Thu, Jul 20, 2023 at 01:44:06PM +0200, Oliver Neukum wrote:
> keeping a list ordered alphabetically instead
> nummerically be vendor/product ID is unusual.
> This is so odd that examples do not help.
> It needs to be clearly stated with strong words.
> 
> Signed-off-by: Oliver Neukum <oneukum@suse.com>
> ---
>  drivers/usb/serial/usb-serial-simple.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/drivers/usb/serial/usb-serial-simple.c b/drivers/usb/serial/usb-serial-simple.c
> index 24b8772a345e..954b3be7403d 100644
> --- a/drivers/usb/serial/usb-serial-simple.c
> +++ b/drivers/usb/serial/usb-serial-simple.c
> @@ -33,6 +33,16 @@ static struct usb_serial_driver vendor##_device = {		\
>  
>  #define DEVICE(vendor, IDS)	DEVICE_N(vendor, IDS, 1)
>  
> +/*
> + * These tables are NOT in order of device id by intention
> + *
> + * Keep them and add new entries sorted by
> + *
> + * 1. Alphabetical order of the vendor name
> + * 2. Alphabetical order of the product name
> + *
> + */

No, this is not correct. The tables are sorted alphabetically based on
the symbol names, but the entries in each table is sorted by VID/PID as
usual.

The table ordering was not there from the start, but I just moved the
offending tables here:

	https://lore.kernel.org/lkml/20230720080049.14032-1-johan@kernel.org/

Guess I should update the sloppy terminology in that commit message,
though.

Johan