Re: [PATCH] Quectel EM05G LTE Modem with new Product ID

[Johan Hovold <johan@kernel.org>]

On Thu, Jul 20, 2023 at 12:30:53PM +0000, Martin Kohn wrote:
> Hello everyone,
> 
> Quectel has changed the product ID for EM05G LTE Modem (global variant), here my verified patch for it:
> 
> From 7a19d929aa07b3541f6a1205cb0ce3f0f5dc54a6 Mon Sep 17 00:00:00 2001
> From: Martin Kohn mailto:m.kohn@welotec.com
> Date: Wed, 19 Jul 2023 12:04:21 +0200
> Subject: [PATCH] Quectel has changed the Product ID from 030a to 030e for the
> EM05G modem. Both versions must be supported in the future.
> 
> Signed-off-by: Martin Kohn mailto:m.kohn@welotec.com
> ---
> drivers/usb/serial/option.c | 3 +++
> 1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
> index 288a96a74266..64b1995b410d 100644
> --- a/drivers/usb/serial/option.c
> +++ b/drivers/usb/serial/option.c
> @@ -256,6 +256,7 @@ static void option_instat_callback(struct urb *urb);
> #define QUECTEL_PRODUCT_BG96                                         0x0296
> #define QUECTEL_PRODUCT_EP06                                         0x0306
> #define QUECTEL_PRODUCT_EM05G                                    0x030a
> +#define QUECTEL_PRODUCT_EM05GV2                              0x030e
> #define QUECTEL_PRODUCT_EM060K                                   0x030b
> #define QUECTEL_PRODUCT_EM05G_CS                             0x030c
> #define QUECTEL_PRODUCT_EM05CN_SG                          0x0310
> @@ -1186,6 +1187,8 @@ static const struct usb_device_id option_ids[] = {
>                  .driver_info = RSVD(6) | ZLP },
>                { USB_DEVICE_INTERFACE_CLASS(QUECTEL_VENDOR_ID, QUECTEL_PRODUCT_EM05G, 0xff),
>                  .driver_info = RSVD(6) | ZLP },
> +        { USB_DEVICE_INTERFACE_CLASS(QUECTEL_VENDOR_ID, QUECTEL_PRODUCT_EM05GV2, 0xff),
> +          .driver_info = RSVD(6) | ZLP },
>                { USB_DEVICE_INTERFACE_CLASS(QUECTEL_VENDOR_ID, QUECTEL_PRODUCT_EM05G_CS, 0xff),
>                  .driver_info = RSVD(6) | ZLP },
>                { USB_DEVICE_INTERFACE_CLASS(QUECTEL_VENDOR_ID, QUECTEL_PRODUCT_EM05G_GR, 0xff),

Your patch is corrupt (e.g. tabs replaced by spaces) and cannot be
applied. It also lacks proper commit summary (Subject) and commit
message.

Take a look at

	https://lore.kernel.org/all/20230710075218.8895-1-moh53n@moh53n.ir/

for a recent example of what this should look like.

Also make sure to send the patch to yourself first and run checkpatch on
it to make sure it's not damaged in transport.

Johan