From: Dan Drown <dan-netdev@drown.org>
To: linux-usb@vger.kernel.org
Subject: [PATCH] usb: cdc-acm: add PPS support
Date: Sat, 5 Aug 2023 21:26:13 -0500 [thread overview]
Message-ID: <ZM8ExV6bAvJtIA1d@vps3.drown.org> (raw)
This patch adds support for PPS to CDC devices. Changes to the DCD pin
are monitored and passed to the ldisc system, which is used by
pps-ldisc.
Signed-off-by: Dan Drown <dan-netdev@drown.org>
---
drivers/usb/class/cdc-acm.c | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c
index 11da5fb284d0..9b34199474c4 100644
--- a/drivers/usb/class/cdc-acm.c
+++ b/drivers/usb/class/cdc-acm.c
@@ -28,6 +28,7 @@
#include <linux/serial.h>
#include <linux/tty_driver.h>
#include <linux/tty_flip.h>
+#include <linux/tty_ldisc.h>
#include <linux/module.h>
#include <linux/mutex.h>
#include <linux/uaccess.h>
@@ -324,8 +325,17 @@ static void acm_process_notification(struct acm *acm, unsigned char *buf)
if (difference & USB_CDC_SERIAL_STATE_DSR)
acm->iocount.dsr++;
- if (difference & USB_CDC_SERIAL_STATE_DCD)
+ if (difference & USB_CDC_SERIAL_STATE_DCD) {
+ if (acm->port.tty) {
+ struct tty_ldisc *ld = tty_ldisc_ref(acm->port.tty);
+ if (ld) {
+ if (ld->ops->dcd_change)
+ ld->ops->dcd_change(acm->port.tty, newctrl & USB_CDC_SERIAL_STATE_DCD);
+ tty_ldisc_deref(ld);
+ }
+ }
acm->iocount.dcd++;
+ }
if (newctrl & USB_CDC_SERIAL_STATE_BREAK) {
acm->iocount.brk++;
tty_insert_flip_char(&acm->port, 0, TTY_BREAK);
--
2.41.0
next reply other threads:[~2023-08-06 2:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-06 2:26 Dan Drown [this message]
2023-08-14 12:32 ` [PATCH] usb: cdc-acm: add PPS support Oliver Neukum
2023-08-15 1:02 ` Dan Drown
2023-08-16 9:50 ` Oliver Neukum
2023-08-16 14:17 ` Dan Drown
2023-08-16 19:58 ` Oliver Neukum
2023-08-17 1:09 ` [PATCH] usb: cdc-acm: move ldisc dcd notification outside of acm's read lock Dan Drown
2023-08-17 8:19 ` Oliver Neukum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZM8ExV6bAvJtIA1d@vps3.drown.org \
--to=dan-netdev@drown.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox