From: Ladislav Michl <oss-lists@triops.cz>
To: Yang Yingliang <yangyingliang@huawei.com>
Cc: linux-usb@vger.kernel.org, Thinh.Nguyen@synopsys.com,
gregkh@linuxfoundation.org
Subject: Re: [PATCH -next] usb: dwc3: dwc3-octeon: remove unnecessary platform_set_drvdata()
Date: Thu, 10 Aug 2023 11:46:05 +0200 [thread overview]
Message-ID: <ZNSx3Qv8ypMbOkho@lenoch> (raw)
In-Reply-To: <20230810015117.3085574-1-yangyingliang@huawei.com>
On Thu, Aug 10, 2023 at 09:51:17AM +0800, Yang Yingliang wrote:
> Remove unnecessary platform_set_drvdata(..., NULL) in ->remove(),
> the driver_data will be cleared in device_unbind_cleanup() after
> calling ->remove() in driver call code.
Isn't the same true also for dwc3-imx8mp, dwc3-keystone and dwc3-am62.c?
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
> drivers/usb/dwc3/dwc3-octeon.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/usb/dwc3/dwc3-octeon.c b/drivers/usb/dwc3/dwc3-octeon.c
> index 6b6581057345..356347780c15 100644
> --- a/drivers/usb/dwc3/dwc3-octeon.c
> +++ b/drivers/usb/dwc3/dwc3-octeon.c
> @@ -517,7 +517,6 @@ static void dwc3_octeon_remove(struct platform_device *pdev)
> struct dwc3_octeon *octeon = platform_get_drvdata(pdev);
>
> of_platform_depopulate(octeon->dev);
> - platform_set_drvdata(pdev, NULL);
> }
>
> static const struct of_device_id dwc3_octeon_of_match[] = {
> --
> 2.25.1
next prev parent reply other threads:[~2023-08-10 9:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-10 1:51 [PATCH -next] usb: dwc3: dwc3-octeon: remove unnecessary platform_set_drvdata() Yang Yingliang
2023-08-10 9:46 ` Ladislav Michl [this message]
2023-08-10 12:31 ` Yang Yingliang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZNSx3Qv8ypMbOkho@lenoch \
--to=oss-lists@triops.cz \
--cc=Thinh.Nguyen@synopsys.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox