From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Biju Das <biju.das.jz@bp.renesas.com>
Cc: Guenter Roeck <linux@roeck-us.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Biju Das <biju.das.au@gmail.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: Re: [PATCH v3 1/5] usb: typec: tcpci_rt1711h: Remove trailing comma in the terminator entry for OF table
Date: Fri, 8 Sep 2023 11:20:30 +0300 [thread overview]
Message-ID: <ZPrZTgx7nVxhHean@kuha.fi.intel.com> (raw)
In-Reply-To: <20230906080619.36930-2-biju.das.jz@bp.renesas.com>
On Wed, Sep 06, 2023 at 09:06:15AM +0100, Biju Das wrote:
> Remove trailing comma in the terminator entry for OF table.
> While at it, drop a space in the terminator for ID table.
>
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> v2->v3:
> * Dropped updating I2C driver data in ID table as there is no user yet.
> * Updated commit header and description.
> * Added Rb tag from Andy.
> * Retained the Rb tag as it is trivial change.
> v1->v2:
> * Drop space from ID table
> * Remove trailing comma in the terminator entry for OF table.
> ---
> drivers/usb/typec/tcpm/tcpci_rt1711h.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/typec/tcpm/tcpci_rt1711h.c b/drivers/usb/typec/tcpm/tcpci_rt1711h.c
> index 17ebc5fb684f..6146bca8e55f 100644
> --- a/drivers/usb/typec/tcpm/tcpci_rt1711h.c
> +++ b/drivers/usb/typec/tcpm/tcpci_rt1711h.c
> @@ -394,7 +394,7 @@ static void rt1711h_remove(struct i2c_client *client)
> static const struct i2c_device_id rt1711h_id[] = {
> { "rt1711h", 0 },
> { "rt1715", 0 },
> - { }
> + {}
> };
> MODULE_DEVICE_TABLE(i2c, rt1711h_id);
>
> @@ -402,7 +402,7 @@ MODULE_DEVICE_TABLE(i2c, rt1711h_id);
> static const struct of_device_id rt1711h_of_match[] = {
> { .compatible = "richtek,rt1711h", .data = (void *)RT1711H_DID },
> { .compatible = "richtek,rt1715", .data = (void *)RT1715_DID },
> - {},
> + {}
> };
> MODULE_DEVICE_TABLE(of, rt1711h_of_match);
> #endif
> --
> 2.25.1
--
heikki
next prev parent reply other threads:[~2023-09-08 8:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-06 8:06 [PATCH v3 0/5] Match data improvements for rt1711h driver Biju Das
2023-09-06 8:06 ` [PATCH v3 1/5] usb: typec: tcpci_rt1711h: Remove trailing comma in the terminator entry for OF table Biju Das
2023-09-08 8:20 ` Heikki Krogerus [this message]
2023-09-06 8:06 ` [PATCH v3 2/5] usb: typec: tcpci_rt1711h: Convert enum->pointer for data in the match tables Biju Das
2023-09-08 8:48 ` Heikki Krogerus
2023-09-06 8:06 ` [PATCH v3 3/5] usb: typec: tcpci_rt1711h: Add rxdz_sel variable to struct rt1711h_chip_info Biju Das
2023-09-08 8:49 ` Heikki Krogerus
2023-09-06 8:06 ` [PATCH v3 4/5] usb: typec: tcpci_rt1711h: Add enable_pd30_extended_message " Biju Das
2023-09-08 10:34 ` Heikki Krogerus
2023-09-06 8:06 ` [PATCH v3 5/5] usb: typec: tcpci_rt1711h: Drop CONFIG_OF ifdeffery Biju Das
2023-09-08 10:40 ` Heikki Krogerus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZPrZTgx7nVxhHean@kuha.fi.intel.com \
--to=heikki.krogerus@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=biju.das.au@gmail.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox