From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CF7F5CA5D for ; Mon, 25 Sep 2023 07:36:50 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F0B18139; Mon, 25 Sep 2023 00:36:49 -0700 (PDT) X-IronPort-AV: E=McAfee;i="6600,9927,10843"; a="381097339" X-IronPort-AV: E=Sophos;i="6.03,174,1694761200"; d="scan'208";a="381097339" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Sep 2023 00:36:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10843"; a="724898625" X-IronPort-AV: E=Sophos;i="6.03,174,1694761200"; d="scan'208";a="724898625" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga006.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Sep 2023 00:36:45 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.97-RC0) (envelope-from ) id 1qkg93-00000000HT0-0yv5; Mon, 25 Sep 2023 10:36:41 +0300 Date: Mon, 25 Sep 2023 10:36:40 +0300 From: Andy Shevchenko To: Duje =?utf-8?Q?Mihanovi=C4=87?= Cc: Daniel Mack , Haojian Zhuang , Robert Jarzmik , Russell King , Alan Stern , Greg Kroah-Hartman , Linus Walleij , Bartosz Golaszewski , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-gpio@vger.kernel.org Subject: Re: [PATCH RFC 5/6] ARM: pxa: Convert Spitz hsync to GPIO descriptors Message-ID: References: <20230924-pxa-gpio-v1-0-2805b87d8894@skole.hr> <20230924-pxa-gpio-v1-5-2805b87d8894@skole.hr> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230924-pxa-gpio-v1-5-2805b87d8894@skole.hr> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_SOFTFAIL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On Sun, Sep 24, 2023 at 06:42:58PM +0200, Duje Mihanović wrote: > Sharp's Spitz still uses the legacy GPIO interface in its wait_for_hsync We refer to the functions as wait_for_hsync(). > function. > > Convert it to use the GPIO descriptor interface. ... > + hsync = gpiod_get(NULL, "hsync", GPIOD_IN); > + if (IS_ERR(hsync)) > + pr_err("Failed to get hsync GPIO: %ld\n", PTR_ERR(hsync)); So, I didn't get, is this GPIO crucial for functioning or optional? If the former, we need to stop here or bail out (if possible), do we? Or should use _optional() API? -- With Best Regards, Andy Shevchenko