From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF90F1391 for ; Sat, 28 Oct 2023 07:02:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Hp0RzgGa" Received: from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com [IPv6:2607:f8b0:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 93E80CA; Sat, 28 Oct 2023 00:02:43 -0700 (PDT) Received: by mail-pl1-x62c.google.com with SMTP id d9443c01a7336-1c77449a6daso24439875ad.0; Sat, 28 Oct 2023 00:02:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698476563; x=1699081363; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=3swEum9c3xS2G6bitOJ9Q/SoUIKvRIQ+YpGFc6w8sw4=; b=Hp0RzgGa6AYU/aLycpwXyKUvQFzDi9YQNouTZ0mVdtAJgS0qqmxNPaS3Usq1cLVyoa AA3IM7rGFD/54uQIzvT0YBkOsVwLO1Uub9RGP96tnta0HYrc7lwrZ6iN1CzC4ZwMSkOU OsDMTD65jqSkvn527q10RXiw0nFlqsE1rLTC8Pg9bkRZxwLJnNZ71bmbXcNr+VUXLUjM DH8WzGJPGWV3l8+H5FrLS/1i8WBR71U9owUGNYhqeE6w5tTqnAB5WzHvKZjhM6VgHfCS 2dMjzuxc8YJQ8zkisvLlEG35DWFdOygD5pJ+g8oXC0tgabSbOFzW/KrqH+p621bHf5hx 7M6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698476563; x=1699081363; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=3swEum9c3xS2G6bitOJ9Q/SoUIKvRIQ+YpGFc6w8sw4=; b=Wl5bJh76DorryO6AIlpdDrrQ6LyoxQlUpzc2j0rKPhcMLn9gDEnTggRwVHCBD0vZn2 bRcSyYL9FHCWagDyvcCIPe9hGet0/Rm8pDZW2NUhtKyDh8vT5uhsBDDDpA0eEaQo9lmV bFS2AUWkaNEEsKHBZuDR1FiRQ3/jXAR1z7EJADMN3GOggk34tjh3P01A93m2xTajTDk2 YfAdkDbOz387ktMYpGVDqlXe5zKbMXin6azMlm6ruBU2qa43dGumADGAFbsPJ4kDAnJD FG3sLhqOErSdegYvOUkk26upMAC7L0PS/uH15au3GNU5zlLllf5GbPcK4ARg9C46yhex U2sg== X-Gm-Message-State: AOJu0YyeaME39zvfW59rKSwcC4rM4zG9vPTppwCeDiWaT7qEgFRTECET UvgXYQWFTvUJC8JIyAl3fTNA2lr74wU= X-Google-Smtp-Source: AGHT+IGa7VL+bQV7Heatz+nnpWDo71U1XmVWXXl+KEQuoET9YsFzFqty1C66Z4w1e6HE943/DXvhqg== X-Received: by 2002:a17:903:2301:b0:1c9:d940:78ea with SMTP id d1-20020a170903230100b001c9d94078eamr5581884plh.22.1698476562930; Sat, 28 Oct 2023 00:02:42 -0700 (PDT) Received: from debian.me ([103.131.18.64]) by smtp.gmail.com with ESMTPSA id l9-20020a170902d34900b001c55db80b14sm958148plk.221.2023.10.28.00.02.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 28 Oct 2023 00:02:42 -0700 (PDT) Received: by debian.me (Postfix, from userid 1000) id 4BB61819CFF3; Sat, 28 Oct 2023 14:02:38 +0700 (WIB) Date: Sat, 28 Oct 2023 14:02:37 +0700 From: Bagas Sanjaya To: LihaSika , Linux USB , Linux USB Storage , Linux Kernel Mailing List Cc: Alan Stern , Greg Kroah-Hartman , Milan Svoboda , Matthieu Castet Subject: Re: [PATCH] usb: storage: set 1.50 as the lower bcdDevice for older "Super Top" compatibility Message-ID: References: <055de764-c422-4c22-a79b-dd4db56122ce@gmail.com> <2023102704-stable-lid-c86a@gregkh> <7484f7c8-a49c-4111-83f0-bb6db2906fae@gmail.com> <2023102729-spent-ninja-7e39@gregkh> <037e5af2-3afd-4a37-a4d7-6dc87af605c7@gmail.com> <21c2b8ee-7753-413e-98f9-d1401edf5c73@gmail.com> <2023102720-emotion-overlying-9bb4@gregkh> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="LBqHn0zx6pxC/YW3" Content-Disposition: inline In-Reply-To: --LBqHn0zx6pxC/YW3 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Oct 27, 2023 at 08:28:04PM +0300, LihaSika wrote: > Change lower bcdDevice value for "Super Top USB 2.0 SATA BRIDGE" to match > 1.50. I have such an older device with bcdDevice=3D1.50 and it will not w= ork > otherwise. What about below description? ``` Some old USB hard drives using Super Top USB 2.0 SATA bridge have lower minimum bcdDevice value than currently allowed (1.60). Such devices cannot be used by ums-cypress driver since their bcdDevice is out of range. Lower minimum bcdDevice to fix that.=20 ``` >=20 > Cc: stable@vger.kernel.org > Signed-off-by: Liha Sikanen Is your intended author name in your From: header or Signed-off-by: trailer? Also, don't forget to add Fixes: tag; that is: Fixes: a9c143c82608 ("usb-storage: restrict bcdDevice range for Super Top i= n Cypress ATACB") When above reviews are addressed, resend as v2. Make sure that the patch subject begins with `[PATCH v2]`. > --- >=20 > diff --git a/drivers/usb/storage/unusual_cypress.h b/drivers/usb/storage/= unusual_cypress.h > index 0547daf..5df4075 100644 > --- a/drivers/usb/storage/unusual_cypress.h > +++ b/drivers/usb/storage/unusual_cypress.h > @@ -19,7 +19,7 @@ UNUSUAL_DEV( 0x04b4, 0x6831, 0x0000, 0x9999, > "Cypress ISD-300LP", > USB_SC_CYP_ATACB, USB_PR_DEVICE, NULL, 0), > =20 > -UNUSUAL_DEV( 0x14cd, 0x6116, 0x0160, 0x0160, > +UNUSUAL_DEV( 0x14cd, 0x6116, 0x0150, 0x0160, > "Super Top", > "USB 2.0 SATA BRIDGE", > USB_SC_CYP_ATACB, USB_PR_DEVICE, NULL, 0), >=20 The diff itself is LGTM. Thanks. --=20 An old man doll... just what I always wanted! - Clara --LBqHn0zx6pxC/YW3 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQSSYQ6Cy7oyFNCHrUH2uYlJVVFOowUCZTyyCQAKCRD2uYlJVVFO o5dIAQDECVFDQwsCIiuYkCORuUPpHseb/kWe2suzrMmWG0ohGAD+OjIHq9yEOFzd R2wA63Yr4JeUOyk4cEwGK5v0lrL98Ac= =3N1E -----END PGP SIGNATURE----- --LBqHn0zx6pxC/YW3--