* [PATCH v1] usb: typec: tcpm: Query Source partner for FRS capability only if it is DRP
@ 2023-12-05 7:47 Kyle Tso
2023-12-08 13:52 ` Heikki Krogerus
2023-12-08 17:00 ` Guenter Roeck
0 siblings, 2 replies; 3+ messages in thread
From: Kyle Tso @ 2023-12-05 7:47 UTC (permalink / raw)
To: linux, heikki.krogerus, gregkh; +Cc: badhri, linux-kernel, linux-usb, Kyle Tso
Source-only port partner will always respond NOT_SUPPORTED to
GET_SINK_CAP. Avoid this redundant AMS by bailing out querying the FRS
capability if the Source port partner is not DRP.
Signed-off-by: Kyle Tso <kyletso@google.com>
---
drivers/usb/typec/tcpm/tcpm.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c
index 50cbc52386b3..192c103e0d10 100644
--- a/drivers/usb/typec/tcpm/tcpm.c
+++ b/drivers/usb/typec/tcpm/tcpm.c
@@ -4401,7 +4401,8 @@ static void run_state_machine(struct tcpm_port *port)
tcpm_set_current_limit(port, tcpm_get_current_limit(port), 5000);
tcpm_swap_complete(port, 0);
tcpm_typec_connect(port);
- mod_enable_frs_delayed_work(port, 0);
+ if (port->pd_capable && port->source_caps[0] & PDO_FIXED_DUAL_ROLE)
+ mod_enable_frs_delayed_work(port, 0);
tcpm_pps_complete(port, port->pps_status);
if (port->ams != NONE_AMS)
--
2.43.0.472.g3155946c3a-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v1] usb: typec: tcpm: Query Source partner for FRS capability only if it is DRP
2023-12-05 7:47 [PATCH v1] usb: typec: tcpm: Query Source partner for FRS capability only if it is DRP Kyle Tso
@ 2023-12-08 13:52 ` Heikki Krogerus
2023-12-08 17:00 ` Guenter Roeck
1 sibling, 0 replies; 3+ messages in thread
From: Heikki Krogerus @ 2023-12-08 13:52 UTC (permalink / raw)
To: Kyle Tso; +Cc: linux, gregkh, badhri, linux-kernel, linux-usb
On Tue, Dec 05, 2023 at 03:47:46PM +0800, Kyle Tso wrote:
> Source-only port partner will always respond NOT_SUPPORTED to
> GET_SINK_CAP. Avoid this redundant AMS by bailing out querying the FRS
> capability if the Source port partner is not DRP.
>
> Signed-off-by: Kyle Tso <kyletso@google.com>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> drivers/usb/typec/tcpm/tcpm.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c
> index 50cbc52386b3..192c103e0d10 100644
> --- a/drivers/usb/typec/tcpm/tcpm.c
> +++ b/drivers/usb/typec/tcpm/tcpm.c
> @@ -4401,7 +4401,8 @@ static void run_state_machine(struct tcpm_port *port)
> tcpm_set_current_limit(port, tcpm_get_current_limit(port), 5000);
> tcpm_swap_complete(port, 0);
> tcpm_typec_connect(port);
> - mod_enable_frs_delayed_work(port, 0);
> + if (port->pd_capable && port->source_caps[0] & PDO_FIXED_DUAL_ROLE)
> + mod_enable_frs_delayed_work(port, 0);
> tcpm_pps_complete(port, port->pps_status);
>
> if (port->ams != NONE_AMS)
> --
> 2.43.0.472.g3155946c3a-goog
--
heikki
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1] usb: typec: tcpm: Query Source partner for FRS capability only if it is DRP
2023-12-05 7:47 [PATCH v1] usb: typec: tcpm: Query Source partner for FRS capability only if it is DRP Kyle Tso
2023-12-08 13:52 ` Heikki Krogerus
@ 2023-12-08 17:00 ` Guenter Roeck
1 sibling, 0 replies; 3+ messages in thread
From: Guenter Roeck @ 2023-12-08 17:00 UTC (permalink / raw)
To: Kyle Tso, heikki.krogerus, gregkh; +Cc: badhri, linux-kernel, linux-usb
On 12/4/23 23:47, Kyle Tso wrote:
> Source-only port partner will always respond NOT_SUPPORTED to
> GET_SINK_CAP. Avoid this redundant AMS by bailing out querying the FRS
> capability if the Source port partner is not DRP.
>
> Signed-off-by: Kyle Tso <kyletso@google.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/usb/typec/tcpm/tcpm.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c
> index 50cbc52386b3..192c103e0d10 100644
> --- a/drivers/usb/typec/tcpm/tcpm.c
> +++ b/drivers/usb/typec/tcpm/tcpm.c
> @@ -4401,7 +4401,8 @@ static void run_state_machine(struct tcpm_port *port)
> tcpm_set_current_limit(port, tcpm_get_current_limit(port), 5000);
> tcpm_swap_complete(port, 0);
> tcpm_typec_connect(port);
> - mod_enable_frs_delayed_work(port, 0);
> + if (port->pd_capable && port->source_caps[0] & PDO_FIXED_DUAL_ROLE)
> + mod_enable_frs_delayed_work(port, 0);
> tcpm_pps_complete(port, port->pps_status);
>
> if (port->ams != NONE_AMS)
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-12-08 17:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-12-05 7:47 [PATCH v1] usb: typec: tcpm: Query Source partner for FRS capability only if it is DRP Kyle Tso
2023-12-08 13:52 ` Heikki Krogerus
2023-12-08 17:00 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox