From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="XdTk2gEk" Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E7CA5DC; Wed, 13 Dec 2023 05:36:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1702474570; x=1734010570; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=NEtuRYz798pOKaCZjGgcl/J6ODZ0hj92ozwgXCg6Ui0=; b=XdTk2gEk9pM5AuOBhy/TaqmUbuUVM1J/QiwqV/b3E3dNK+1DvbvykoHD ie+cnsiYARFD0/Re77n3pl5XqxNsk6PjH5gbjYE0nFFQ0ZHObJF3GFa5G YiBEgDUOxt7n4NZ425PLnZ9NTVgz8arXIiTBQTBbsBSML/J/JIJII9GTN tHRyhGo0I2kaaolzWAwRVmMwKNZpRLBzy2ZrlXK6c2JpIYSpMvoUv19ws 98lblFJDIfDudk8JJeeNcZYr+nXAFqSYvILWXvyCY8iJb/d8HRLh4Ac99 hzU5ulMYjB9YGtBGx8mhlHNSUTnza16kWgIO8gsncql7REoNyQX/JXXN1 w==; X-IronPort-AV: E=McAfee;i="6600,9927,10922"; a="8354476" X-IronPort-AV: E=Sophos;i="6.04,272,1695711600"; d="scan'208";a="8354476" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Dec 2023 05:36:10 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10922"; a="750108795" X-IronPort-AV: E=Sophos;i="6.04,272,1695711600"; d="scan'208";a="750108795" Received: from kuha.fi.intel.com ([10.237.72.185]) by orsmga006.jf.intel.com with SMTP; 13 Dec 2023 05:36:06 -0800 Received: by kuha.fi.intel.com (sSMTP sendmail emulation); Wed, 13 Dec 2023 15:36:05 +0200 Date: Wed, 13 Dec 2023 15:36:05 +0200 From: Heikki Krogerus To: Christophe JAILLET Cc: Greg Kroah-Hartman , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH] usb: typec: Remove usage of the deprecated ida_simple_xx() API Message-ID: References: Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Sun, Dec 10, 2023 at 06:36:15PM +0100, Christophe JAILLET wrote: > ida_alloc() and ida_free() should be preferred to the deprecated > ida_simple_get() and ida_simple_remove(). > > This is less verbose. > > Signed-off-by: Christophe JAILLET Acked-by: Heikki Krogerus > --- > drivers/usb/typec/class.c | 8 ++++---- > drivers/usb/typec/pd.c | 4 ++-- > 2 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/usb/typec/class.c b/drivers/usb/typec/class.c > index 16a670828dde..5fe01bf795b9 100644 > --- a/drivers/usb/typec/class.c > +++ b/drivers/usb/typec/class.c > @@ -476,7 +476,7 @@ static int altmode_id_get(struct device *dev) > else > ids = &to_typec_port(dev)->mode_ids; > > - return ida_simple_get(ids, 0, 0, GFP_KERNEL); > + return ida_alloc(ids, GFP_KERNEL); > } > > static void altmode_id_remove(struct device *dev, int id) > @@ -490,7 +490,7 @@ static void altmode_id_remove(struct device *dev, int id) > else > ids = &to_typec_port(dev)->mode_ids; > > - ida_simple_remove(ids, id); > + ida_free(ids, id); > } > > static void typec_altmode_release(struct device *dev) > @@ -1798,7 +1798,7 @@ static void typec_release(struct device *dev) > { > struct typec_port *port = to_typec_port(dev); > > - ida_simple_remove(&typec_index_ida, port->id); > + ida_free(&typec_index_ida, port->id); > ida_destroy(&port->mode_ids); > typec_switch_put(port->sw); > typec_mux_put(port->mux); > @@ -2297,7 +2297,7 @@ struct typec_port *typec_register_port(struct device *parent, > if (!port) > return ERR_PTR(-ENOMEM); > > - id = ida_simple_get(&typec_index_ida, 0, 0, GFP_KERNEL); > + id = ida_alloc(&typec_index_ida, GFP_KERNEL); > if (id < 0) { > kfree(port); > return ERR_PTR(id); > diff --git a/drivers/usb/typec/pd.c b/drivers/usb/typec/pd.c > index 85d015cdbe1f..7f3d61f220f2 100644 > --- a/drivers/usb/typec/pd.c > +++ b/drivers/usb/typec/pd.c > @@ -571,7 +571,7 @@ static void pd_release(struct device *dev) > { > struct usb_power_delivery *pd = to_usb_power_delivery(dev); > > - ida_simple_remove(&pd_ida, pd->id); > + ida_free(&pd_ida, pd->id); > kfree(pd); > } > > @@ -616,7 +616,7 @@ usb_power_delivery_register(struct device *parent, struct usb_power_delivery_des > if (!pd) > return ERR_PTR(-ENOMEM); > > - ret = ida_simple_get(&pd_ida, 0, 0, GFP_KERNEL); > + ret = ida_alloc(&pd_ida, GFP_KERNEL); > if (ret < 0) { > kfree(pd); > return ERR_PTR(ret); > -- > 2.34.1 -- heikki