From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-il1-f171.google.com (mail-il1-f171.google.com [209.85.166.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 98089134BA for ; Tue, 6 Feb 2024 18:41:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707244862; cv=none; b=AeFrmlCK4K5PviqHAb1OW78UmS4xlU7WixXWNPm0X4RsFXqcj3YdBUrlXrKl5xQ3n3LXvUfk8fvhXp5AIUkxRJOs63c5PHOiu1sTDyuqjplCzZ87oz0E2ZtZN0D5sNcTm9H3jBwqmJEjogeg7ASLPuQkJ+ZX2X0SzxXKpopoIio= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707244862; c=relaxed/simple; bh=4iMUCDRK0tbwCoq9ax96HYxDL0mnKXeCT6CGUsUHlLY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=B4hNrOkYw0eakmn1I4EYrbe6NPh61dfEMSeNKdmpWlPSyPy4w8aVy4UA4gftA+LkU6yXxKyzP5W63OseVRNKrDM50t0HLnahFa35Lb2h5OZ1u0sNdpn4SO1/850PZtOmmoWwarGuvNYQcXkyWIBxLneJXtmdKAUVdPYrFExS8+Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=DPsh6ovd; arc=none smtp.client-ip=209.85.166.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="DPsh6ovd" Received: by mail-il1-f171.google.com with SMTP id e9e14a558f8ab-363d953a6c5so769005ab.1 for ; Tue, 06 Feb 2024 10:41:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1707244859; x=1707849659; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=+Xv9kD5QhjTCn8Q0pWh79kSOAjDdZQG/rInb+Rd12sQ=; b=DPsh6ovd0cSK3rj11e7ONTc9yz4uuL4plAcyRNbUMiqMVKxKvyoTCkcn8eft79qa5n E5Ej7nCko1mRC8nRJD0d9KbAaJ0swKBgccCdwXXQe94PGxgWjNayxEJDXRCvnLiF72Lb VX3PPsAlCLzAeL78dYMIlvMKjrTUdDn4fOhzI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707244859; x=1707849659; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+Xv9kD5QhjTCn8Q0pWh79kSOAjDdZQG/rInb+Rd12sQ=; b=YuAXyMPhjCE1bRjV/0uHqmZQcNwb0cXxp1gjENB/QTI5qf9M3SnmdHq7D38Wf1SiWU Q3BYWIv8BZJQje7d45jdqb+sOx7MoGOHSOBv3tdPkVu4NjJ+dQ5khO9wy1E6tTIzVigo P1+axCCFmYgoLxHxbDZi40UPiI4Lq/iXECYgBfgtxdN9a0BrahSMBb9Ovtvaj0r38lVL mYmQRiNa3xq4DoBClam+mhmsZs0TsL9lTbJZefVRkp7pmsZK9KSUQnXpdZuLU29Josdu LMRNe4PBk1ILZp9euNbmtNrfvvGigov0Nin/21UxrS1D+bS8IjaMsi6fiCWVeLxDXhPl 9l0g== X-Gm-Message-State: AOJu0YwSBt7dw4GkeZMXstKWiKwtssF1jFxTAFdp/aViRKJqefAs6bz6 ALP2sxCq7H2LH2aFjRhGgD+NKrjSZrih5/5CatDT71tlB/XmHwtamCL92T03vf5bbijss8hRGWU = X-Google-Smtp-Source: AGHT+IH/hHo4kYBuL5vCw54nvX8pPrZtO2JH3Q3ZlUbStO7TCJYcZnDxXL5gfiQUMQeIheFecJGkuw== X-Received: by 2002:a92:cd83:0:b0:363:bc81:47f8 with SMTP id r3-20020a92cd83000000b00363bc8147f8mr4910691ilb.21.1707244859728; Tue, 06 Feb 2024 10:40:59 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCVr5FtOxk/NPujxjkxVAGBIFYTCd68ni8q4C1vR0Wa9BaHegqYv6Q/GEOczSL0kI7ZNx6NBqpgs/wUd+QwVY/bt2uow70wn0cCw60Ehlx08PSO77hd2EZVpWqo4AapEYw3YL4eqqbIbPqWQvR9Vt9O/5t6PDaYGIr6qV9Wo+TcT2yRmiwA05PSd2BW/A89Jy5THeLi8iOxte+gFCo/IFA90t0CNAvJJioD9eBrRbpV5AncwkM3WxgE2x00ewnfaOKO586M2Yl7Qqd7ZjwbfjLgVhi4450iNxIsjGrTDiEyFnWfNuVRNSlm5cPa4vc6uuER8wO0H2XAkA5IJrM7V/CkTgUi6u6hHVcMi1hWrzGjYQF5tV2O5tZJxKLpEVsa4UbBs1Dpa2gEoJfTnLFc= Received: from localhost (147.220.222.35.bc.googleusercontent.com. [35.222.220.147]) by smtp.gmail.com with UTF8SMTPSA id t5-20020a05663801e500b00471476d36a1sm234311jaq.116.2024.02.06.10.40.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 Feb 2024 10:40:59 -0800 (PST) Date: Tue, 6 Feb 2024 18:40:58 +0000 From: Matthias Kaehlcke To: Javier Carrasco Cc: Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Greg Kroah-Hartman , linux-sound@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH v3 2/7] usb: misc: onboard_dev: add support for non-hub devices Message-ID: References: <20240206-onboard_xvf3500-v3-0-f85b04116688@wolfvision.net> <20240206-onboard_xvf3500-v3-2-f85b04116688@wolfvision.net> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240206-onboard_xvf3500-v3-2-f85b04116688@wolfvision.net> On Tue, Feb 06, 2024 at 02:59:30PM +0100, Javier Carrasco wrote: > Most of the functionality this driver provides can be used by non-hub > devices as well. > > To account for the hub-specific code, add a flag to the device data > structure and check its value for hub-specific code. > > Signed-off-by: Javier Carrasco > --- > drivers/usb/misc/onboard_usb_dev.c | 3 +++ > drivers/usb/misc/onboard_usb_dev.h | 10 ++++++++++ > 2 files changed, 13 insertions(+) > > diff --git a/drivers/usb/misc/onboard_usb_dev.c b/drivers/usb/misc/onboard_usb_dev.c > index e2e1e1e30c1e..3ac21ec38ac0 100644 > --- a/drivers/usb/misc/onboard_usb_dev.c > +++ b/drivers/usb/misc/onboard_usb_dev.c > @@ -123,6 +123,9 @@ static int __maybe_unused onboard_dev_suspend(struct device *dev) > if (onboard_dev->always_powered_in_suspend) > return 0; > > + if (!onboard_dev->pdata->is_hub) > + return onboard_dev_power_off(onboard_dev); Why turn the device always off when it isn't a hub? It could be a device with wakeup support. I really regret making 'off in suspend' the default :( > + > mutex_lock(&onboard_dev->lock); > > list_for_each_entry(node, &onboard_dev->udev_list, list) { > diff --git a/drivers/usb/misc/onboard_usb_dev.h b/drivers/usb/misc/onboard_usb_dev.h > index f13d11a84371..ebe83e19d818 100644 > --- a/drivers/usb/misc/onboard_usb_dev.h > +++ b/drivers/usb/misc/onboard_usb_dev.h > @@ -9,51 +9,61 @@ > struct onboard_dev_pdata { > unsigned long reset_us; /* reset pulse width in us */ > unsigned int num_supplies; /* number of supplies */ > + bool is_hub; > }; > > static const struct onboard_dev_pdata microchip_usb424_data = { > .reset_us = 1, > .num_supplies = 1, > + .is_hub = true, Depending on when 'is_hub' is checked it could be an option to initialize it at runtime (depending on USB_CLASS_HUB), e.g. in onboard_dev_add_usbdev(). Might not be worth the hassle tough if more than the current check(s) get added. > }; > > static const struct onboard_dev_pdata microchip_usb5744_data = { > .reset_us = 0, > .num_supplies = 2, > + .is_hub = true, > }; > > static const struct onboard_dev_pdata realtek_rts5411_data = { > .reset_us = 0, > .num_supplies = 1, > + .is_hub = true, > }; > > static const struct onboard_dev_pdata ti_tusb8041_data = { > .reset_us = 3000, > .num_supplies = 1, > + .is_hub = true, > }; > > static const struct onboard_dev_pdata cypress_hx3_data = { > .reset_us = 10000, > .num_supplies = 2, > + .is_hub = true, > }; > > static const struct onboard_dev_pdata cypress_hx2vl_data = { > .reset_us = 1, > .num_supplies = 1, > + .is_hub = true, > }; > > static const struct onboard_dev_pdata genesys_gl850g_data = { > .reset_us = 3, > .num_supplies = 1, > + .is_hub = true, > }; > > static const struct onboard_dev_pdata genesys_gl852g_data = { > .reset_us = 50, > .num_supplies = 1, > + .is_hub = true, > }; > > static const struct onboard_dev_pdata vialab_vl817_data = { > .reset_us = 10, > .num_supplies = 1, > + .is_hub = true, > }; > > static const struct of_device_id onboard_dev_match[] = { > > -- > 2.40.1 >