From: Johan Hovold <johan@kernel.org>
To: Colin Ian King <colin.i.king@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] USB: serial: keyspan: Remove redundant assignment to pointer data
Date: Mon, 4 Mar 2024 14:55:22 +0100 [thread overview]
Message-ID: <ZeXSyit1fq5CFJSc@hovoldconsulting.com> (raw)
In-Reply-To: <20240207104128.2441210-1-colin.i.king@gmail.com>
On Wed, Feb 07, 2024 at 10:41:28AM +0000, Colin Ian King wrote:
> The pointer data is being assigned a value that is not being
> read afterwards, it is being re-assigned later inside a do-while
> loop. The assignment is redundant and can be removed.
>
> Cleans up clang scan warning:
> drivers/usb/serial/keyspan.c:924:2: warning: Value stored to 'data'
> is never read [deadcode.DeadStores]
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Applied, thanks.
Johan
prev parent reply other threads:[~2024-03-04 13:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-07 10:41 [PATCH][next] USB: serial: keyspan: Remove redundant assignment to pointer data Colin Ian King
2024-03-04 13:55 ` Johan Hovold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZeXSyit1fq5CFJSc@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=colin.i.king@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).