* [PATCH][next] USB: serial: keyspan: Remove redundant assignment to pointer data
@ 2024-02-07 10:41 Colin Ian King
2024-03-04 13:55 ` Johan Hovold
0 siblings, 1 reply; 2+ messages in thread
From: Colin Ian King @ 2024-02-07 10:41 UTC (permalink / raw)
To: Johan Hovold, Greg Kroah-Hartman, linux-usb; +Cc: kernel-janitors, linux-kernel
The pointer data is being assigned a value that is not being
read afterwards, it is being re-assigned later inside a do-while
loop. The assignment is redundant and can be removed.
Cleans up clang scan warning:
drivers/usb/serial/keyspan.c:924:2: warning: Value stored to 'data'
is never read [deadcode.DeadStores]
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
drivers/usb/serial/keyspan.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/usb/serial/keyspan.c b/drivers/usb/serial/keyspan.c
index 93b17e0e05a3..0a783985197c 100644
--- a/drivers/usb/serial/keyspan.c
+++ b/drivers/usb/serial/keyspan.c
@@ -921,7 +921,6 @@ static void usa28_indat_callback(struct urb *urb)
port = urb->context;
p_priv = usb_get_serial_port_data(port);
- data = urb->transfer_buffer;
if (urb != p_priv->in_urbs[p_priv->in_flip])
return;
--
2.39.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH][next] USB: serial: keyspan: Remove redundant assignment to pointer data
2024-02-07 10:41 [PATCH][next] USB: serial: keyspan: Remove redundant assignment to pointer data Colin Ian King
@ 2024-03-04 13:55 ` Johan Hovold
0 siblings, 0 replies; 2+ messages in thread
From: Johan Hovold @ 2024-03-04 13:55 UTC (permalink / raw)
To: Colin Ian King
Cc: Greg Kroah-Hartman, linux-usb, kernel-janitors, linux-kernel
On Wed, Feb 07, 2024 at 10:41:28AM +0000, Colin Ian King wrote:
> The pointer data is being assigned a value that is not being
> read afterwards, it is being re-assigned later inside a do-while
> loop. The assignment is redundant and can be removed.
>
> Cleans up clang scan warning:
> drivers/usb/serial/keyspan.c:924:2: warning: Value stored to 'data'
> is never read [deadcode.DeadStores]
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Applied, thanks.
Johan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-03-04 13:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-07 10:41 [PATCH][next] USB: serial: keyspan: Remove redundant assignment to pointer data Colin Ian King
2024-03-04 13:55 ` Johan Hovold
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).