From: Johan Hovold <johan@kernel.org>
To: Krishna Kurapati PSSNV <quic_kriskura@quicinc.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
Wesley Cheng <quic_wcheng@quicinc.com>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, quic_ppratap@quicinc.com,
quic_jackp@quicinc.com
Subject: Re: [PATCH] usb: dwc3: qcom: Remove ACPI support from glue driver
Date: Tue, 5 Mar 2024 09:26:22 +0100 [thread overview]
Message-ID: <ZebXLkA9kXzx6qNi@hovoldconsulting.com> (raw)
In-Reply-To: <0c2c039e-b49e-4172-9c7f-24061e3ac5c6@quicinc.com>
On Tue, Mar 05, 2024 at 01:47:05PM +0530, Krishna Kurapati PSSNV wrote:
> On 3/5/2024 12:39 PM, Johan Hovold wrote:
> > On Tue, Mar 05, 2024 at 09:51:43AM +0530, Krishna Kurapati wrote:
> > You should update the Kconfig entry for USB_DWC3_QCOM as well and drop
> > the ACPI dependency.
>
> Missed it. Thanks for the catch. The following is the one right ?
>
> diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig
> index 5fc27b20df63..31078f3d41b8 100644
> --- a/drivers/usb/dwc3/Kconfig
> +++ b/drivers/usb/dwc3/Kconfig
> @@ -131,7 +131,7 @@ config USB_DWC3_QCOM
> tristate "Qualcomm Platform"
> depends on ARCH_QCOM || COMPILE_TEST
> depends on EXTCON || !EXTCON
> - depends on (OF || ACPI)
> + depends on OF
Right.
> > Looks good to me otherwise.
>
> Thanks for the review. Wanted to reply to your comments on multiport
> series depending on how this patch goes in upstream.
>
> Can I push out v2 or wait for a couple of days (as a standard practice
> before putting a new version) ?
I think you can send a v2 straight away in this case.
Johan
prev parent reply other threads:[~2024-03-05 8:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-05 4:21 [PATCH] usb: dwc3: qcom: Remove ACPI support from glue driver Krishna Kurapati
2024-03-05 7:09 ` Johan Hovold
2024-03-05 8:17 ` Krishna Kurapati PSSNV
2024-03-05 8:26 ` Johan Hovold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZebXLkA9kXzx6qNi@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=Thinh.Nguyen@synopsys.com \
--cc=andersson@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=quic_jackp@quicinc.com \
--cc=quic_kriskura@quicinc.com \
--cc=quic_ppratap@quicinc.com \
--cc=quic_wcheng@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox