Re: [PATCH 2/7] usb: serial: mos7720: don't advertise PARPORT_MODE_PCSPP

Daniel Gimpelevich
2024-03-12T15:27:58Z

On Tue, 2024-03-12 at 09:53 +0000, Sudip Mukherjee wrote:
> On Tue, 12 Mar 2024 at 07:39, Johan Hovold <johan@kernel.org> wrote:
> >
> > On Mon, Mar 11, 2024 at 11:50:27PM -0600, Alex Henrie wrote:
> >
> > This one and at least one of the later ones are also missing commit
> > messages. Please fix in a v2.
>
> It will be a NACK from me.
>
> This patch and other patches removing PARPORT_MODE_PCSPP will break
> userspace code.
> On my system, I have:
> $ cat /proc/sys/dev/parport/parport0/modes
> PCSPP,TRISTATE
>
> If the flag is removed then I will only get "TRISTATE", and if there
> is any userspace code which checks for the mode then those
> applications will stop working with an error.

This patch seems like some sort of backscatter from
https://en.wikipedia.org/wiki/XY_problem issues.