From: Johan Hovold <johan@kernel.org>
To: Lars Melin <larsm17@gmail.com>, Coia Prant <coiaprant@gmail.com>
Cc: linux-usb@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH 1/2] USB: serial: option: add Lonsung U8300/U9300 product Update the USB serial option driver to support Longsung U8300/U9300.
Date: Mon, 15 Apr 2024 08:53:46 +0200 [thread overview]
Message-ID: <ZhzO-re7GMmI5fbP@hovoldconsulting.com> (raw)
In-Reply-To: <64053ff1-c447-45c5-ba87-e85307143dd4@gmail.com>
On Tue, Apr 02, 2024 at 03:09:12PM +0700, Lars Melin wrote:
> On 2024-04-02 14:34, Coia Prant wrote:
You're Subject is missing two newline characters to separate the commit
summary from the commit message.
> > ID 1c9e:9b05 OMEGA TECHNOLOGY (U8300)
> > ID 1c9e:9b3c OMEGA TECHNOLOGY (U9300)
> >
> > U8300
> > /: Bus
> > |__ Port 1: Dev 3, If 0, Class=Vendor Specific Class, Driver=option, 480M (Debug)
> > ID 1c9e:9b05 OMEGA TECHNOLOGY
> > |__ Port 1: Dev 3, If 1, Class=Vendor Specific Class, Driver=option, 480M (Modem / AT)
> > ID 1c9e:9b05 OMEGA TECHNOLOGY
> > |__ Port 1: Dev 3, If 2, Class=Vendor Specific Class, Driver=option, 480M (AT)
> > ID 1c9e:9b05 OMEGA TECHNOLOGY
> > |__ Port 1: Dev 3, If 3, Class=Vendor Specific Class, Driver=option, 480M (AT / Pipe / PPP)
> > ID 1c9e:9b05 OMEGA TECHNOLOGY
> > |__ Port 1: Dev 3, If 4, Class=Vendor Specific Class, Driver=qmi_wwan, 480M (NDIS / GobiNet / QMI WWAN)
> > ID 1c9e:9b05 OMEGA TECHNOLOGY
> > |__ Port 1: Dev 3, If 5, Class=Vendor Specific Class, Driver=, 480M (ADB)
> > ID 1c9e:9b05 OMEGA TECHNOLOGY
Could please use the more condensed output of the usb-devices command
(for both devices) which is better suited for a commit message?
> Reviewed-by Lars Melin (larsm17@gmail.com
>
> added the maintainer to the recipient list
Thanks for reviewing, Lars.
Coia, you can include Lars's Reviewed-by tag when you send a v2.
Johan
prev parent reply other threads:[~2024-04-15 6:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-02 7:34 [PATCH 1/2] USB: serial: option: add Lonsung U8300/U9300 product Update the USB serial option driver to support Longsung U8300/U9300 Coia Prant
2024-04-02 8:09 ` Lars Melin
2024-04-15 6:53 ` Johan Hovold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZhzO-re7GMmI5fbP@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=coiaprant@gmail.com \
--cc=larsm17@gmail.com \
--cc=linux-usb@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox