Re: [PATCH] USB: serial: qcserial: add support for Sierra Wireless EM7511

[Reinhard Speyerer <rspmn@arcor.de>]

On Fri, Aug 23, 2024 at 09:35:53PM +0300, alon.barlev@gmail.com wrote:
> From: Alon Bar-Lev <alon.barlev@gmail.com>
> 
> Add support for Sierra Wireless EM7511 0x90b0/0x90b1 compositions.
> 
> Signed-off-by: Alon Bar-Lev <alon.barlev@gmail.com>
> ---
>  drivers/usb/serial/qcserial.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/usb/serial/qcserial.c b/drivers/usb/serial/qcserial.c
> index 703a9c563557..4e19536a603c 100644
> --- a/drivers/usb/serial/qcserial.c
> +++ b/drivers/usb/serial/qcserial.c
> @@ -165,6 +165,8 @@ static const struct usb_device_id id_table[] = {
>  	{DEVICE_SWI(0x1199, 0x907b)},	/* Sierra Wireless EM74xx */
>  	{DEVICE_SWI(0x1199, 0x9090)},	/* Sierra Wireless EM7565 QDL */
>  	{DEVICE_SWI(0x1199, 0x9091)},	/* Sierra Wireless EM7565 */
> +	{DEVICE_SWI(0x1199, 0x90b0)},	/* Sierra Wireless EM7511 QDL */
> +	{DEVICE_SWI(0x1199, 0x90b1)},	/* Sierra Wireless EM7511 */

Hi Alon,

the interface layout for the DEVICE_SWI(0x1199, 0x90b1) entry from your patch
disagrees with the usb-devices output from
https://forum.sierrawireless.com/t/em7565-1199-90b1-usbx-qcserial-issue-ubuntu-20-04-mbpl-driver-fail-to-compile/26361
and the Sierra Wireless MBPL_DRIVER_R27_ENG2-usb-src.tar.gz driver attached
to this thread https://forum.sierrawireless.com/t/driver-make-error/30702 .

As a consequence the DIAG interface would not be supported by the mainline
Linux kernel.

Regards,
Reinhard