[PATCH v6 0/8] usb: typec: Implement UCSI driver for ChromeOS

Łukasz Bartosik
2024-09-10T10:15:37Z

This series implements a UCSI ChromeOS EC transport driver.
The ChromeOS EC is expected to implement UCSI Platform Policy
Manager (PPM).

---
Changes in v6:
- Reverted to type names uint*_t in cros_ec_commands.h in order
to be consistent with type names used in other parts of the file.
- Updated comments in cros_ec_commands.h related to UCSI.
- Added missing sign-offs.
- Fixed memory leak in cros_ucsi_async_control() by moving
ec_params_ucsi_ppm_set request buffer to stack.
- Replaced cros_ucsi_read with cros_ucsi_read_cci in cros_ucsi_work().
- Updated changes in v5, it was missing information related to
commits addition:
platform/chrome: Update EC feature flags
usb: typec: cros_ec_ucsi: Use complete instead of resume
mfd: cros_ec: Load cros_ec_ucsi on supported ECs
mfd: cros_ec: Don't load charger with UCSI
- Link to v5: https://lore.kernel.org/r/all/20240903163033.3170815-1-ukaszb@chromium.org/

Changes in v5:
- Increased WRITE_TMO_MS to 5000.
- Replaced DRV_NAME with KBUILD_MODNAME.
- Added comments for WRITE_TMO_MS and MAX_EC_DATA_SIZE defines.
- Refactored cros_ucsi_async_control() to dynamically allocate memory
for a message to EC instead of allocating the message on stack.
- Replaced type names uint*_t with u*.
- Removed ret variable in cros_ucsi_work().
- Updated ucsi_operations interface to align with changes introduced in
v6.11.
- Replaced test_bit() with test_and_clear_bit() in cros_ucsi_work().
- Updated EC feature flags in commit "platform/chrome: Update EC feature
flags".
- Added new commit "usb: typec: cros_ec_ucsi: Use complete instead
of resume".
- Added trace events in commit "usb: typec: cros_ec_ucsi: Add trace
events".
- Added netlink in commit "usb: typec: cros_ec_ucsi: Add netlink"
for debugging and testing puropses.
- Added new commit "mfd: cros_ec: Load cros_ec_ucsi on supported ECs".
- Added new commit "mfd: cros_ec: Don't load charger with UCSI".
- Link to v4: https://lore.kernel.org/all/CAB2FV=6We88NrvN8NZYt8NkMFH9N_ZBGyUWVUpGwPdja2X_+NA@mail.gmail.com/T/

Changes in v4:
- Setup notifications before calling ucsi_register.
- Cancel work before destroying driver data.
- Link to v3: https://lore.kernel.org/r/20240403-public-ucsi-h-v3-0-f848e18c8ed2@chromium.org

Changes in v3:
- Moved driver from platform/chrome to usb/typec/ucsi.
- Used id_table instead of MODULE_ALIAS.
- Split EC header changes into seperate commit.
- Fixes from additional internal reviews and kernel bot warnings.
- Link to v2: https://lore.kernel.org/r/20240325-public-ucsi-h-v2-0-a6d716968bb1@chromium.org

Changes in v2:
- No code or commit message changes.
- Added drivers/platform/chrome maintainers for review.
- Link to v1: https://lore.kernel.org/r/20240325-public-ucsi-h-v1-0-7c7e888edc0a@chromium.org

Abhishek Pandit-Subedi (2):
usb: typec: cros_ec_ucsi: Use complete instead of resume
mfd: cros_ec: Don't load charger with UCSI

Pavan Holla (4):
platform/chrome: Update ChromeOS EC header for UCSI
platform/chrome: Update EC feature flags
usb: typec: ucsi: Implement ChromeOS UCSI driver
mfd: cros_ec: Load cros_ec_ucsi on supported ECs

Łukasz Bartosik (2):
usb: typec: cros_ec_ucsi: Add trace events
usb: typec: cros_ec_ucsi: Add netlink

MAINTAINERS | 10 +
drivers/mfd/cros_ec_dev.c | 25 +-
drivers/usb/typec/ucsi/Kconfig | 13 +
drivers/usb/typec/ucsi/Makefile | 3 +
drivers/usb/typec/ucsi/cros_ec_ucsi_main.c | 346 ++++++++++++++++++
drivers/usb/typec/ucsi/cros_ec_ucsi_nl.c | 87 +++++
drivers/usb/typec/ucsi/cros_ec_ucsi_nl.h | 52 +++
drivers/usb/typec/ucsi/cros_ec_ucsi_trace.h | 92 +++++
.../linux/platform_data/cros_ec_commands.h | 60 ++-
9 files changed, 684 insertions(+), 4 deletions(-)
create mode 100644 drivers/usb/typec/ucsi/cros_ec_ucsi_main.c
create mode 100644 drivers/usb/typec/ucsi/cros_ec_ucsi_nl.c
create mode 100644 drivers/usb/typec/ucsi/cros_ec_ucsi_nl.h
create mode 100644 drivers/usb/typec/ucsi/cros_ec_ucsi_trace.h

--
2.46.0.598.g6f2099f65c-goog