From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: "Łukasz Bartosik" <ukaszb@chromium.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Lee Jones <lee@kernel.org>, Benson Leung <bleung@chromium.org>,
Guenter Roeck <groeck@chromium.org>,
Abhishek Pandit-Subedi <abhishekpandit@chromium.org>,
Pavan Holla <pholla@chromium.org>,
Tzung-Bi Shih <tzungbi@kernel.org>,
linux-usb@vger.kernel.org, chrome-platform@lists.linux.dev
Subject: Re: [PATCH v6 6/8] usb: typec: cros_ec_ucsi: Add netlink
Date: Thu, 19 Sep 2024 12:38:09 +0300 [thread overview]
Message-ID: <ZuvxAQmMsnIYZMTP@kuha.fi.intel.com> (raw)
In-Reply-To: <CALwA+Nb6zWe-WOgcu8-ni5OCx9XxerVhi76fZze2KP_kmFVonA@mail.gmail.com>
On Sun, Sep 15, 2024 at 12:08:45AM +0200, Łukasz Bartosik wrote:
> On Wed, Sep 11, 2024 at 4:09 PM Heikki Krogerus
> <heikki.krogerus@linux.intel.com> wrote:
> >
> > Hi,
> >
> > On Tue, Sep 10, 2024 at 10:15:25AM +0000, Łukasz Bartosik wrote:
> > > Add netlink to ChromeOS UCSI driver to allow forwarding
> > > of UCSI messages to userspace for debugging and testing
> > > purposes.
> >
> > Why does this need to be cros_ec specific?
> >
>
> You're right. Netlink does not have to be cros_ec_ucsi specific.
> Would you like to have netlink in typec_ucsi ?
Does it need to be netlink? We would then have tracepoints, the
custom debugfs interface, and this netlink interface.
I think this information could be exposed via trancepoints (unless I'm
missing something).
Br,
--
heikki
next prev parent reply other threads:[~2024-09-19 9:38 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-10 10:15 [PATCH v6 0/8] usb: typec: Implement UCSI driver for ChromeOS Łukasz Bartosik
2024-09-10 10:15 ` [PATCH v6 1/8] platform/chrome: Update ChromeOS EC header for UCSI Łukasz Bartosik
2024-09-18 6:32 ` Tzung-Bi Shih
2024-09-10 10:15 ` [PATCH v6 2/8] platform/chrome: Update EC feature flags Łukasz Bartosik
2024-09-18 6:32 ` Tzung-Bi Shih
2024-10-11 7:27 ` Lee Jones
2024-10-11 9:17 ` Łukasz Bartosik
2024-10-15 9:10 ` (subset) " Lee Jones
2024-09-10 10:15 ` [PATCH v6 3/8] usb: typec: ucsi: Implement ChromeOS UCSI driver Łukasz Bartosik
2024-09-12 12:58 ` Dmitry Baryshkov
2024-09-14 22:50 ` Łukasz Bartosik
2024-09-14 23:03 ` Dmitry Baryshkov
2024-09-14 23:43 ` Łukasz Bartosik
2024-09-10 10:15 ` [PATCH v6 4/8] usb: typec: cros_ec_ucsi: Use complete instead of resume Łukasz Bartosik
2024-09-11 13:20 ` Heikki Krogerus
2024-09-14 21:50 ` Łukasz Bartosik
2024-09-10 10:15 ` [PATCH v6 5/8] usb: typec: cros_ec_ucsi: Add trace events Łukasz Bartosik
2024-09-11 13:36 ` Heikki Krogerus
2024-09-14 21:52 ` Łukasz Bartosik
2024-09-19 12:52 ` Heikki Krogerus
2024-09-19 18:10 ` Łukasz Bartosik
2024-09-10 10:15 ` [PATCH v6 6/8] usb: typec: cros_ec_ucsi: Add netlink Łukasz Bartosik
2024-09-11 14:00 ` kernel test robot
2024-09-11 14:07 ` Heikki Krogerus
2024-09-14 22:08 ` Łukasz Bartosik
2024-09-19 9:38 ` Heikki Krogerus [this message]
2024-09-19 18:03 ` Łukasz Bartosik
2024-09-19 20:00 ` Dmitry Baryshkov
2024-09-23 14:42 ` Łukasz Bartosik
2024-09-21 7:11 ` kernel test robot
2024-09-10 10:15 ` [PATCH v6 7/8] mfd: cros_ec: Load cros_ec_ucsi on supported ECs Łukasz Bartosik
2024-09-10 10:15 ` [PATCH v6 8/8] mfd: cros_ec: Don't load charger with UCSI Łukasz Bartosik
2024-10-09 10:11 ` (subset) " Lee Jones
2024-10-09 10:11 ` (subset) [PATCH v6 0/8] usb: typec: Implement UCSI driver for ChromeOS Lee Jones
2024-10-15 9:10 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZuvxAQmMsnIYZMTP@kuha.fi.intel.com \
--to=heikki.krogerus@linux.intel.com \
--cc=abhishekpandit@chromium.org \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=gregkh@linuxfoundation.org \
--cc=groeck@chromium.org \
--cc=lee@kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=pholla@chromium.org \
--cc=tzungbi@kernel.org \
--cc=ukaszb@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox