From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Amit Sunil Dhamne <amitsd@google.com>
Cc: gregkh@linuxfoundation.org, robh@kernel.org,
dmitry.baryshkov@linaro.org, badhri@google.com,
kyletso@google.com, rdbabiera@google.com,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [RFC v3 2/2] usb: typec: tcpm: Add support for parsing time dt properties
Date: Tue, 24 Sep 2024 15:55:14 +0300 [thread overview]
Message-ID: <ZvK2slBHR8PhzaMt@kuha.fi.intel.com> (raw)
In-Reply-To: <20240923224059.3674414-3-amitsd@google.com>
Hi,
> @@ -7611,10 +7650,13 @@ struct tcpm_port *tcpm_register_port(struct device *dev, struct tcpc_dev *tcpc)
> err = tcpm_fw_get_caps(port, tcpc->fwnode);
> if (err < 0)
> goto out_destroy_wq;
> +
This extra newline is not relevant or necessary. Otherwise this LGTM:
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> err = tcpm_fw_get_snk_vdos(port, tcpc->fwnode);
> if (err < 0)
> goto out_destroy_wq;
>
> + tcpm_fw_get_timings(port, tcpc->fwnode);
> +
> port->try_role = port->typec_caps.prefer_role;
>
> port->typec_caps.revision = 0x0120; /* Type-C spec release 1.2 */
thanks,
--
heikki
next prev parent reply other threads:[~2024-09-24 12:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-23 22:40 [RFC v3 0/2] Add support for time DT property in TCPM Amit Sunil Dhamne
2024-09-23 22:40 ` [RFC v3 1/2] dt-bindings: connector: Add properties to define time values Amit Sunil Dhamne
2024-09-24 23:04 ` Rob Herring (Arm)
2024-09-23 22:40 ` [RFC v3 2/2] usb: typec: tcpm: Add support for parsing time dt properties Amit Sunil Dhamne
2024-09-24 12:55 ` Heikki Krogerus [this message]
2024-09-25 2:44 ` Amit Sunil Dhamne
2024-09-25 3:16 ` Amit Sunil Dhamne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZvK2slBHR8PhzaMt@kuha.fi.intel.com \
--to=heikki.krogerus@linux.intel.com \
--cc=amitsd@google.com \
--cc=badhri@google.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=kyletso@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=rdbabiera@google.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).