From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B82F51CFEA9 for ; Tue, 15 Oct 2024 13:03:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728997439; cv=none; b=S6THiIqlOSG1A4GH66op3fnI4w8YiTKpyOoLcJl5iNDix0rioGULzODff9qnfVEqIPWdg3i2msM1k+Xu6g58XDP+/bk84Am6Z4fhDQcIycImC3lZyo3PtNODx7nL6Fcoiqdejyf8IkJlt79ufMC0kaWiFTFXzXm1uD6pKMS1oEI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728997439; c=relaxed/simple; bh=Lm5YIENHSH8hxbG0wrGckxliJKkAAMXevVGs6pPXiPU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=WvybAr2DxrpYC1i/c5VxyltYXuZXsi/RsFjVUmHQuuXLIsZrJEpKvez4fvpzrvp6ILdBhFHmRej639jAvw0FiSY1QwSc0b+nNnqy64ghAmjL08FjwNP7VMlUoQO+C9T+HoizoknTqg6ZbH6Ww5bN7trT5v7RTvrSrD556f1ALyc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=GFQMCrj9; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="GFQMCrj9" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-37d4c482844so3078992f8f.0 for ; Tue, 15 Oct 2024 06:03:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1728997436; x=1729602236; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=EfIzmMIc+jdVgSYVjow3yI+R+7mv8rjwXVSvx3G/YCI=; b=GFQMCrj9COIog/XbFbp4xW5FY823b5ZkIPcHIIn9h0T85dJLfx4QzUtE/vpyhJDqyV LtSpydD8rAC6+AcEynhiaV/tzdxsid67cSGFg1ZTv57FQQEdep59+AfMLqG8RcmqNRW6 jQy54wd17RLGUnC/RCX228zvb1eb7Mehg5cOerVeyeX0xtJt41yf7W4JXff7rFelgm/f 0wGcT5+yNfEP688deutdnfIUBMRKeQOPMaCVsMtk8P7fVVFALdJG+Bta/fpV4NSvlCWO TpbzXCwCV5po3jHhh4wv1y6OLKjDv4U/PaDQuVKcrpQXfPP8ijX1ajQUDLmBZiIrdBWQ Idfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728997436; x=1729602236; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=EfIzmMIc+jdVgSYVjow3yI+R+7mv8rjwXVSvx3G/YCI=; b=pT4SYXgvMgpjSoUpp+x6AObwG+JqV7Vj5kBdLbd53bJkUVK+Z7rpkZuzxOEd30hkNH snn9Rfc6awESbdmYHoSK3dQjNhCCZYabU2D0v68nJT6kI+sxS78aFEnNyb1w2sKzzBRS SFmObseYhJh59MxSbzdRbn6L7AGPfgVp+XeqhNXL3bGp+ZSVEYR8zAWVtphxQyw45gvS 8ay8Vtmr3HsIoIXeJc0GT2X4mpslcrUWZhwEXw8EmnOZQeLL8FheC/bnlWJrTzqueJSN maSg32097PB0gU74dnv330QRuG1f6c/B/OiaqwdKLqzZgrQBMNDRlnukx+ALBYn5BBx5 lnVg== X-Forwarded-Encrypted: i=1; AJvYcCX9v7cbdWUkLs2UwOyPz9xJWCXokirVZVfvobbddvo+rsgN+XC64pXcebx+EifnOwZ24Mpjbw5ITpY=@vger.kernel.org X-Gm-Message-State: AOJu0YyzE0TYqE2Olk7VJsVtLgGDGNNLQw9WeQpuTeEoM63XqMtSLrjE JKJ6OTi3uD8P8/6Y0a2bWR1Xc5jeyYikdIEaiku5zCNN01FDcW1nZ6YxSDVhWzI= X-Google-Smtp-Source: AGHT+IHKKw5qg6qbRVjnDX1hYY/Pzy5t1f9uZ94XN/UZxWzYk2Hnf7NTq3WQyOH5g/aqVcr2jdVcjw== X-Received: by 2002:a05:6000:1869:b0:37d:4f1b:35d with SMTP id ffacd0b85a97d-37d86d69878mr159053f8f.48.1728997435755; Tue, 15 Oct 2024 06:03:55 -0700 (PDT) Received: from linaro.org ([82.76.168.176]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4313f55dfa8sm17806825e9.6.2024.10.15.06.03.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Oct 2024 06:03:55 -0700 (PDT) Date: Tue, 15 Oct 2024 16:03:53 +0300 From: Abel Vesa To: Johan Hovold Cc: Heikki Krogerus , Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, Bjorn Andersson , Konrad Dybcio , Rajendra Nayak , Sibi Sankar , Dmitry Baryshkov , Trilok Soni , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v2 0/2] usb: typec: Add new driver for Parade PS8830 Type-C Retimer Message-ID: References: <20241004-x1e80100-ps8830-v2-0-5cd8008c8c40@linaro.org> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On 24-10-15 14:41:25, Johan Hovold wrote: > On Fri, Oct 04, 2024 at 04:57:36PM +0300, Abel Vesa wrote: > > The Parade PS8830 is a Type-C multi-protocol retimer that is controlled > > via I2C. It provides altmode and orientation handling and usually sits > > between the Type-C port and the PHY. > > > > It is currently used alongside Qualcomm Snapdragon X Elite SoCs on quite > > a few laptops already. > > > > This new driver adds support for the following 3 modes: > > - DP 4lanes (pin assignments C and E) > > - DP 2lanes + USB3 (pin assignment D) > > - USB3 > > > > This retimer is a LTTPR (Link-Training Tunable PHY Repeater) which means > > it can support link training from source to itself. This means that the > > DP driver needs to be aware of the repeater presence and to handle > > the link training accordingly. This is currently missing from msm dp > > driver, but there is already effort going on to add it. Once done, > > full external DP will be working on all X1E laptops that make use of > > this retimer. > > I was gonna ask you to include the devicetree changes that enables the > retimers as part of this series (to facilitate review and testing), but > perhaps you should indeed not post them again until LTTPR support is in > place. I was thinking maybe we should not wait for LTTPR support as this series brings orientation support as is. I still need to figure out how to strip out the DP parts of it in such a way that orientation should still be working but DP should not (until LTTPR is in). > > > Signed-off-by: Abel Vesa > > --- > > Changes in v2: > > - Addressed all comments from Johan and Konrad. > > - Reworked the handling of the vregs so it would be more cleaner. > > Dropped the usage of bulk regulators API and handled them separately. > > Also discribed all regulators according to data sheet. > > - Added all delays according to data sheet. > > - Fixed coldplug (on boot) orientation detection. > > Coldplug orientation detection still does not work here with this series > applied. > > I'm not entirely sure this whether worked better with v1, but with v2 > my SuperSpeed ethernet device shows up as a HighSpeed device in one > orientation. It is also not disconnected an re-enumerated as SS as is > the case on the X13s (and possibly with v1): > > usb 1-1: new high-speed USB device number 2 using xhci-hcd For coldplug, this series does the right thing as it leaves the retimer initialized if it was left enabled at boot. There is a second part needed for the coldplug to work. That is the regulator-boot-on property in retimer's vregs nodes. That will ensure that the regulator is not disabled until retimer driver probes and will keep the retimer initialized until USB device is enumerated. > > > - Didn't pick Krzysztof's R-b tag because the bindings changed w.r.t > > supplies. > > - Link to v1: https://lore.kernel.org/r/20240829-x1e80100-ps8830-v1-0-bcc4790b1d45@linaro.org > > > > --- > > Abel Vesa (2): > > dt-bindings: usb: Add Parade PS8830 Type-C retimer bindings > > usb: typec: Add support for Parade PS8830 Type-C Retimer > > Johan