Re: [PATCH v3 2/4] usb: typec: Add support for Parade PS8830 Type-C Retimer

Heikki Krogerus
2024-10-22T14:11:50Z

Hi,

Couple of nitpicks.

On Tue, Oct 22, 2024 at 01:26:55PM +0300, Abel Vesa wrote:
> +static int ps8830_retimer_probe(struct i2c_client *client)
> +{
> + struct device *dev = &client->dev;
> + struct typec_switch_desc sw_desc = { };
> + struct typec_retimer_desc rtmr_desc = { };
> + struct ps8830_retimer *retimer;
> + bool skip_reset = false;
> + int ret;
> +
> + retimer = devm_kzalloc(dev, sizeof(*retimer), GFP_KERNEL);
> + if (!retimer)
> + return -ENOMEM;
> +
> + retimer->client = client;
> +
> + mutex_init(&retimer->lock);
> +
> + if (of_property_read_bool(dev->of_node, "ps8830,boot-on"))
> + skip_reset = true;

skip_reset = device_property_present(dev, "ps8830,boot-on");

> + retimer->regmap = devm_regmap_init_i2c(client, &ps8830_retimer_regmap);
> + if (IS_ERR(retimer->regmap)) {
> + ret = PTR_ERR(retimer->regmap);
> + dev_err(dev, "failed to allocate register map: %d\n", ret);
> + return ret;
> + }
> +
> + ret = ps8830_get_vregs(retimer);
> + if (ret)
> + return ret;
> +
> + retimer->xo_clk = devm_clk_get(dev, "xo");
> + if (IS_ERR(retimer->xo_clk))
> + return dev_err_probe(dev, PTR_ERR(retimer->xo_clk),
> + "failed to get xo clock\n");
> +
> + retimer->reset_gpio = devm_gpiod_get(dev, "reset",
> + skip_reset ? GPIOD_OUT_LOW : GPIOD_OUT_HIGH);
> + if (IS_ERR(retimer->reset_gpio))
> + return dev_err_probe(dev, PTR_ERR(retimer->reset_gpio),
> + "failed to get reset gpio\n");
> +
> + retimer->typec_switch = fwnode_typec_switch_get(dev->fwnode);

retimer->typec_switch = typec_switch_get(dev);

> + if (IS_ERR(retimer->typec_switch))
> + return dev_err_probe(dev, PTR_ERR(retimer->typec_switch),
> + "failed to acquire orientation-switch\n");
> +
> + retimer->typec_mux = fwnode_typec_mux_get(dev->fwnode);

retimer->typec_mux = typec_mux_get(dev);

> + if (IS_ERR(retimer->typec_mux)) {
> + ret = dev_err_probe(dev, PTR_ERR(retimer->typec_mux),
> + "failed to acquire mode-mux\n");
> + goto err_switch_put;
> + }
> +
> + sw_desc.drvdata = retimer;
> + sw_desc.fwnode = dev_fwnode(dev);
> + sw_desc.set = ps8830_sw_set;
> +
> + ret = drm_aux_bridge_register(dev);
> + if (ret)
> + goto err_mux_put;
> +
> + retimer->sw = typec_switch_register(dev, &sw_desc);
> + if (IS_ERR(retimer->sw)) {
> + ret = PTR_ERR(retimer->sw);
> + dev_err(dev, "failed to register typec switch: %d\n", ret);
> + goto err_aux_bridge_unregister;
> + }
> +
> + rtmr_desc.drvdata = retimer;
> + rtmr_desc.fwnode = dev_fwnode(dev);
> + rtmr_desc.set = ps8830_retimer_set;
> +
> + retimer->retimer = typec_retimer_register(dev, &rtmr_desc);
> + if (IS_ERR(retimer->retimer)) {
> + ret = PTR_ERR(retimer->retimer);
> + dev_err(dev, "failed to register typec retimer: %d\n", ret);
> + goto err_switch_unregister;
> + }
> +
> + ret = clk_prepare_enable(retimer->xo_clk);
> + if (ret) {
> + dev_err(dev, "failed to enable XO: %d\n", ret);
> + goto err_retimer_unregister;
> + }
> +
> + ret = ps8830_enable_vregs(retimer);
> + if (ret)
> + goto err_clk_disable;
> +
> + /* delay needed as per datasheet */
> + usleep_range(4000, 14000);
> +
> + if (!skip_reset)
> + gpiod_set_value(retimer->reset_gpio, 0);
> +
> + return 0;
> +
> +err_clk_disable:
> + clk_disable_unprepare(retimer->xo_clk);
> +err_retimer_unregister:
> + typec_retimer_unregister(retimer->retimer);
> +err_switch_unregister:
> + typec_switch_unregister(retimer->sw);
> +err_aux_bridge_unregister:
> + if (!skip_reset)
> + gpiod_set_value(retimer->reset_gpio, 1);
> +
> + clk_disable_unprepare(retimer->xo_clk);
> +err_mux_put:
> + typec_mux_put(retimer->typec_mux);
> +err_switch_put:
> + typec_switch_put(retimer->typec_switch);
> +
> + return ret;
> +}

thanks,

--
heikki