Re: [PATCH v3 4/4] arm64: dts: qcom: x1e80100-crd: Enable external DP

Bjorn Andersson
2024-10-23T00:32:21Z

On Tue, Oct 22, 2024 at 01:26:57PM GMT, Abel Vesa wrote:
> Enable the remaining MDSS DP instances and force 2 data lanes for each DP.

Please document why you're forcing 2 data lanes for each DP (should this
restriction remain when we add support for 4 lanes?) - and I would be
extra happy if you spelled out your abbreviations.

Regards,
Bjorn

>
> Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> ---
> arch/arm64/boot/dts/qcom/x1e80100-crd.dts | 24 ++++++++++++++++++++++++
> 1 file changed, 24 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/x1e80100-crd.dts b/arch/arm64/boot/dts/qcom/x1e80100-crd.dts
> index 7cc45a5cd7eb7e70915d04ea7e181b56f693f768..db36e3e1a3660f3bcd7d7ddc8286e1ff5d00c94a 100644
> --- a/arch/arm64/boot/dts/qcom/x1e80100-crd.dts
> +++ b/arch/arm64/boot/dts/qcom/x1e80100-crd.dts
> @@ -1105,6 +1105,30 @@ &mdss {
> status = "okay";
> };
>
> +&mdss_dp0 {
> + status = "okay";
> +};
> +
> +&mdss_dp0_out {
> + data-lanes = <0 1>;
> +};
> +
> +&mdss_dp1 {
> + status = "okay";
> +};
> +
> +&mdss_dp1_out {
> + data-lanes = <0 1>;
> +};
> +
> +&mdss_dp2 {
> + status = "okay";
> +};
> +
> +&mdss_dp2_out {
> + data-lanes = <0 1>;
> +};
> +
> &mdss_dp3 {
> compatible = "qcom,x1e80100-dp";
> /delete-property/ #sound-dai-cells;
>
> --
> 2.34.1
>