From: Johan Hovold <johan@kernel.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Heikki Krogerus <heikki.krogeurs@linux.intel.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org, Abel Vesa <abel.vesa@linaro.org>,
Johan Hovold <johan+linaro@kernel.org>
Subject: Re: [PATCH 1/2] usb: typec: ucsi: glink: fix off-by-one in connector_status
Date: Fri, 8 Nov 2024 16:56:29 +0100 [thread overview]
Message-ID: <Zy40rRqrWEbZKFsu@hovoldconsulting.com> (raw)
In-Reply-To: <20241106-ucsi-glue-fixes-v1-1-d0183d78c522@linaro.org>
On Wed, Nov 06, 2024 at 05:45:54PM +0200, Dmitry Baryshkov wrote:
> UCSI connector's indices start from 1 up to 3, PMIC_GLINK_MAX_PORTS.
> Correct the condition in the pmic_glink_ucsi_connector_status()
> callback, fixing Type-C orientation reporting for the third USB-C
> connector.
>
> Fixes: 76716fd5bf09 ("usb: typec: ucsi: glink: move GPIO reading into connector_status callback")
> Reported-by: Abel Vesa <abel.vesa@linaro.org>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Nice find!
With CC-stable tag added:
Reviewed-by: Johan Hovold <johan+linaro@kernel.org>
Tested-by: Johan Hovold <johan+linaro@kernel.org>
next prev parent reply other threads:[~2024-11-08 15:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-06 15:45 [PATCH 0/2] usb: typec: ucsi: glink: fix and improve orientation handling Dmitry Baryshkov
2024-11-06 15:45 ` [PATCH 1/2] usb: typec: ucsi: glink: fix off-by-one in connector_status Dmitry Baryshkov
2024-11-07 5:17 ` Greg Kroah-Hartman
2024-11-07 11:04 ` Dmitry Baryshkov
2024-11-07 8:36 ` neil.armstrong
2024-11-08 15:56 ` Johan Hovold [this message]
2024-11-06 15:45 ` [PATCH 2/2] usb: typec: ucsi: glink: be more precise on orientation-aware ports Dmitry Baryshkov
2024-11-06 17:13 ` Abel Vesa
2024-11-07 5:18 ` Greg Kroah-Hartman
2024-11-07 10:02 ` Dmitry Baryshkov
2024-11-07 8:37 ` neil.armstrong
2024-11-08 15:57 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zy40rRqrWEbZKFsu@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=abel.vesa@linaro.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=heikki.krogeurs@linux.intel.com \
--cc=johan+linaro@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox