From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Abhishek Pandit-Subedi <abhishekpandit@chromium.org>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
"Katiyar, Pooja" <pooja.katiyar@intel.com>
Cc: Jameson Thies <jthies@google.com>,
Benson Leung <bleung@chromium.org>,
Bartosz Szpila <bszpila@google.com>,
"Pilla, Siva sai kumar" <siva.sai.kumar.pilla@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org
Subject: Re: [PATCH v1] usb: typec: ucsi: Convert connector specific commands to bitmaps
Date: Fri, 1 Nov 2024 10:31:54 +0200 [thread overview]
Message-ID: <ZySR-iYLCZLLZFah@kuha.fi.intel.com> (raw)
In-Reply-To: <20241031154122.2641624-1-heikki.krogerus@linux.intel.com>
> +/* Helpers to access cached command responses. */
> +#define UCSI_CONCAP(_con_, _field_) \
> + ucsi_bitfield_read((_con_)->status, UCSI_CONCAP_##_field_, (_con_)->ucsi->version)
Pooja noticed (off-list) that I forgot to fix this part - "status"
should be "cap" here. Thanks for cathing that.
> +#define UCSI_CONSTAT(_con_, _field_) \
> + ucsi_bitfield_read((_con_)->status, UCSI_CONSTAT_##_field_, (_con_)->ucsi->version)
>
> /* -------------------------------------------------------------------------- */
thanks,
--
heikki
next prev parent reply other threads:[~2024-11-01 8:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-31 15:41 [PATCH v1] usb: typec: ucsi: Convert connector specific commands to bitmaps Heikki Krogerus
2024-11-01 8:31 ` Heikki Krogerus [this message]
2024-11-01 17:30 ` Abhishek Pandit-Subedi
2024-11-05 9:27 ` Heikki Krogerus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZySR-iYLCZLLZFah@kuha.fi.intel.com \
--to=heikki.krogerus@linux.intel.com \
--cc=abhishekpandit@chromium.org \
--cc=bleung@chromium.org \
--cc=bszpila@google.com \
--cc=dmitry.baryshkov@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=jthies@google.com \
--cc=linux-usb@vger.kernel.org \
--cc=pooja.katiyar@intel.com \
--cc=siva.sai.kumar.pilla@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).