From: Luis Felipe Hernandez <luis.hernandez093@gmail.com>
To: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
Cc: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"rbm@suse.com" <rbm@suse.com>,
"skhan@linuxfoundation.org" <skhan@linuxfoundation.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel-mentees@lists.linuxfoundation.org"
<linux-kernel-mentees@lists.linuxfoundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] usb: dwc3: remove unused sg struct member
Date: Wed, 20 Nov 2024 09:17:26 -0500 [thread overview]
Message-ID: <Zz3vdkEzSobJ54bI@x13> (raw)
In-Reply-To: <20241119221907.tyt4luboduaymukl@synopsys.com>
Thanks, Thinh and Greg, for the feedback!
On Tue, Nov 19, 2024 at 10:19:09PM +0000, Thinh Nguyen wrote:
> > Previously, this patch addressed a documentation warning caused by the
>
> Remove this paragraph. This context only makes sense in this thread
> where the previous patch version is visible.
>
I’ll update the commit message and remove the unnecessary paragraph as suggested.
> > Reported-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
>
> I'm not the one who should be attributed to by the Reported-by tag.
>
> I think Greg was alluding to this report by Stephen Rothwell:
> https://lore.kernel.org/all/20241118194006.77c7b126@canb.auug.org.au/
>
> It wasn't Cc to the linux-usb list, so I'm not sure if you've seen it.
> If your change was base on the report above, then you can update the
> Reported-by tag accordingly.
>
Regarding the report by Stephen Rothwell, I wasn’t aware of it before. I found the warning independently while trying to compile the Documentation subsystem, looking for bugs to address.
That said, now that I’m aware of Stephen’s thread, I wouldn’t mind updating the commit message to include a reference to it if you think it would help link the two discussions. Let me know your thoughts on this.
Thanks again for the clarification and the reviews!
Best,
Felipe
next prev parent reply other threads:[~2024-11-20 14:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-19 21:24 [PATCH v3] usb: dwc3: remove unused sg struct member Luis Felipe Hernandez
2024-11-19 22:19 ` Thinh Nguyen
2024-11-20 14:17 ` Luis Felipe Hernandez [this message]
2024-11-20 14:25 ` gregkh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zz3vdkEzSobJ54bI@x13 \
--to=luis.hernandez093@gmail.com \
--cc=Thinh.Nguyen@synopsys.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=rbm@suse.com \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).