From: Mathias Nyman <mathias.nyman@linux.intel.com>
To: Henry Lin <henryl@nvidia.com>
Cc: Mathias Nyman <mathias.nyman@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] usb: xhci: only set D3hot for pci device
Date: Tue, 19 Nov 2019 16:57:36 +0200 [thread overview]
Message-ID: <a06cd930-01d4-da57-1606-69e78566abb3@linux.intel.com> (raw)
In-Reply-To: <20191119081656.8746-1-henryl@nvidia.com>
On 19.11.2019 10.16, Henry Lin wrote:
> Xhci driver cannot call pci_set_power_state() on non-pci xhci host
> controllers. For example, NVIDIA Tegra XHCI host controller which acts
> as platform device with XHCI_SPURIOUS_WAKEUP quirk set in some platform
> hits this issue during shutdown.
>
> Signed-off-by: Henry Lin <henryl@nvidia.com>
Thanks, looks great.
I like this solution.
Keeps original code sequence, removes pci specific calls from generic xhci code,
and at the same time it fixes the NVIDIA Tegra xHC shutdown issue.
Adding to queue
-Mathias
next prev parent reply other threads:[~2019-11-19 14:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-12 7:18 [PATCH] usb: xhci: only set D3hot for pci device Henry Lin
2019-11-13 1:49 ` [PATCH v2] " Henry Lin
2019-11-15 15:05 ` Mathias Nyman
2019-11-19 7:46 ` Henry Lin
2019-11-19 8:16 ` [PATCH v3] " Henry Lin
2019-11-19 14:57 ` Mathias Nyman [this message]
2019-11-20 19:16 ` Jack Pham
[not found] ` <0101016e8a3ed405-a70f7e87-8c4b-4759-910f-9b9753a9dabb-000000@us-west-2.amazonses.com>
2019-11-21 1:53 ` Henry Lin
2019-11-21 2:07 ` [PATCH v4] " Henry Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a06cd930-01d4-da57-1606-69e78566abb3@linux.intel.com \
--to=mathias.nyman@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=henryl@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).