From: Diogo Ivo <diogo.ivo@siemens.com>
To: Mark Pearson <mpearson-lenovo@squebb.ca>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Greg KH <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: typec: ucsi: treat get_pdos not supported condition as info instead of error
Date: Thu, 6 Jun 2024 16:47:04 +0100 [thread overview]
Message-ID: <a11a3cf2-5e25-471f-ad74-4834d3540e1d@siemens.com> (raw)
In-Reply-To: <a517bb13-9772-49f9-b75c-8fa4d98b2ae9@app.fastmail.com>
Hi Mark,
On 6/5/24 6:09 PM, Mark Pearson wrote:
>
> @@ -645,9 +645,13 @@ static int ucsi_read_pdos(struct ucsi_connector *con,
> static int ucsi_get_pdos(struct ucsi_connector *con, enum typec_role role,
> int is_partner, u32 *pdos)
> {
> + struct ucsi *ucsi = con->ucsi;
> u8 num_pdos;
> int ret;
>
> + if (!(ucsi->cap.features & UCSI_CAP_PDO_DETAILS))
> + return 0;
> +
> /* UCSI max payload means only getting at most 4 PDOs at a time */
> ret = ucsi_read_pdos(con, role, is_partner, pdos, 0, UCSI_MAX_PDOS);
>
Seems good to me too.
Best regards,
Diogo
next prev parent reply other threads:[~2024-06-06 15:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-04 19:40 [PATCH] usb: typec: ucsi: treat get_pdos not supported condition as info instead of error Mark Pearson
2024-06-04 23:45 ` Dmitry Baryshkov
2024-06-05 17:09 ` Mark Pearson
2024-06-05 23:26 ` Dmitry Baryshkov
2024-06-06 2:12 ` Mark Pearson
2024-06-06 15:47 ` Diogo Ivo [this message]
2024-06-05 10:10 ` Diogo Ivo
2024-06-05 15:29 ` Diogo Ivo
2024-06-05 16:24 ` Mark Pearson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a11a3cf2-5e25-471f-ad74-4834d3540e1d@siemens.com \
--to=diogo.ivo@siemens.com \
--cc=dmitry.baryshkov@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mpearson-lenovo@squebb.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox