From: Sergei Shtylyov <sergei.shtylyov@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Karina Yankevich <k.yankevich@omp.ru>
Cc: Alan Stern <stern@rowland.harvard.edu>,
linux-usb@vger.kernel.org, usb-storage@lists.one-eyed-alien.net,
linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org
Subject: Re: [PATCH v2] usb: storage: sddr55: clean up variable type
Date: Fri, 1 Dec 2023 19:16:56 +0300 [thread overview]
Message-ID: <a1296b9a-c27e-3b35-e256-32350fb2a83e@gmail.com> (raw)
In-Reply-To: <Y/yaB2A8qwgRkqVO@kroah.com>
Hello!
Sorry for the really long delay! Your reply scared off Karina
(it was her 1st kernel patch), so I'm trying to pick this patch up
where it was left back in February...
On 2/27/23 2:54 PM, Greg Kroah-Hartman wrote:
[...]
>> SVACE static analyzer complains that we're possibly
>> losing information by shifting an 'unsigned int pba'
>> variables in sddr55_{read,write}_data().
>> It is a false positive, because of the card's total capacity
>> is no larger than 128 MB. But 'unsigned int' is more
>> suitable in this case.
>
> Please wrap at 72 columns.
>
>> Found by OMP on behalf of Linux Verification Center
>> (linuxtesting.org) with SVACE.
>
> What is "OMP"?
Open Mobile Platform, LLC. The website is in Russian only:
https://www.omp.ru
> What is "SVACE"?
The patch description said thst it's a static analyzer.
Here's the link to the Institute for System Programming web page about it:
https://www.ispras.ru/en/technologies/svace/
> And why change anything if there is not a real issue?
We needlessly use 64-bit type on 64-bit arches.
>> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
>
> That's obviously not the correct commit id for such a "fix" as this is
> not a real issue.
That's correct. We'll remove this tag.
> thanks,
>
> greg k-h
MBR, Srrgey
next prev parent reply other threads:[~2023-12-01 16:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-03 20:18 [PATCH] usb: storage: sddr55: avoid integer overflow Karina Yankevich
2023-02-03 20:48 ` Alan Stern
2023-02-06 20:04 ` Sergei Shtylyov
2023-02-06 20:17 ` Alan Stern
2023-02-27 11:25 ` [PATCH v2] usb: storage: sddr55: clean up variable type Karina Yankevich
2023-02-27 11:54 ` Greg Kroah-Hartman
2023-12-01 16:16 ` Sergei Shtylyov [this message]
2023-12-01 22:36 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a1296b9a-c27e-3b35-e256-32350fb2a83e@gmail.com \
--to=sergei.shtylyov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=k.yankevich@omp.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=stern@rowland.harvard.edu \
--cc=usb-storage@lists.one-eyed-alien.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox