From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
To: Dominique Martinet <dominique.martinet@atmark-techno.com>,
Richard Leitner <richard.leitner@linux.dev>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: usb251xb: silence EPROBE_DEFER error on boot
Date: Mon, 3 Feb 2025 07:22:33 +0100 [thread overview]
Message-ID: <a2e4d538-5406-437f-a09d-0cb811d7d399@wanadoo.fr> (raw)
In-Reply-To: <20250203-defer_usb1-v1-1-f6bba254215d@atmark-techno.com>
Le 03/02/2025 à 07:08, Dominique Martinet a écrit :
> Use dev_err_probe to silence EPROBE_DEFER error on boot:
> [ 0.757677] usb251xb 1-002c: failed to get ofdata: -517
>
> Signed-off-by: Dominique Martinet <dominique.martinet@atmark-techno.com>
> ---
> drivers/usb/misc/usb251xb.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/usb/misc/usb251xb.c b/drivers/usb/misc/usb251xb.c
> index e24cdb667307802b9eee856e20744ebf694395e8..ed7c99621fc9af57c988b2298a576248b329ba3d 100644
> --- a/drivers/usb/misc/usb251xb.c
> +++ b/drivers/usb/misc/usb251xb.c
> @@ -637,8 +637,7 @@ static int usb251xb_probe(struct usb251xb *hub)
> if (np && usb_data) {
> err = usb251xb_get_ofdata(hub, usb_data);
> if (err) {
> - dev_err(dev, "failed to get ofdata: %d\n", err);
> - return err;
> + return dev_err_probe(dev, err, "failed to get ofdata: %d\n", err);
> }
extra { } can also be removed now that there is only 1 line left.
CJ
> }
>
>
> ---
> base-commit: 2014c95afecee3e76ca4a56956a936e23283f05b
> change-id: 20250203-defer_usb1-254070d18cc9
>
> Best regards,
prev parent reply other threads:[~2025-02-03 6:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-03 6:08 [PATCH] usb: usb251xb: silence EPROBE_DEFER error on boot Dominique Martinet
2025-02-03 6:20 ` Christophe JAILLET
2025-02-03 6:22 ` Christophe JAILLET [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a2e4d538-5406-437f-a09d-0cb811d7d399@wanadoo.fr \
--to=christophe.jaillet@wanadoo.fr \
--cc=dominique.martinet@atmark-techno.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=richard.leitner@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox