From: Florian Fainelli <f.fainelli@gmail.com>
To: Saurav Girepunje <saurav.girepunje@gmail.com>,
cernekee@gmail.com, balbi@kernel.org, gregkh@linuxfoundation.org,
f.fainelli@gmail.com, bcm-kernel-feedback-list@broadcom.com,
linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Cc: saurav.girepunje@hotmail.com
Subject: Re: [PATCH] usb: gadget: udc:bcm63xx_udc: use devm_platform_ioremap_resource
Date: Mon, 28 Oct 2019 11:24:48 -0700 [thread overview]
Message-ID: <a337b82b-c046-de6a-7bad-68d05f4b44a1@gmail.com> (raw)
In-Reply-To: <20191025143533.GA7068@saurav>
On 10/25/19 7:35 AM, Saurav Girepunje wrote:
> Use the new helper that wraps the calls to platform_get_resource()
> and devm_ioremap_resource() together in bcm63xx_udc_probe().
>
> Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
This looks fine, in your subject, there should be an additional space
between udc: and use devm_... other than that:
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
parent reply other threads:[~2019-10-28 18:24 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20191025143533.GA7068@saurav>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a337b82b-c046-de6a-7bad-68d05f4b44a1@gmail.com \
--to=f.fainelli@gmail.com \
--cc=balbi@kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=cernekee@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=saurav.girepunje@gmail.com \
--cc=saurav.girepunje@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).