Re: [PATCH v2] remove indentation for common path [linux-next]

Joe Perches
2024-04-21T01:27:58Z

On Sun, 2024-04-21 at 06:13 +0530, sundar wrote:
> On 20/04/24 22:37, Joe Perches wrote:
> > On Sat, 2024-04-20 at 22:19 +0530, sundar wrote:
> >
> >
> > > ```
> > @@ -321,35 +321,37 @@ static int nb7vpq904m_parse_data_lanes_mapping(struct nb7vpq904m *nb7)
> >
> > ep = of_graph_get_endpoint_by_regs(nb7->client->dev.of_node, 1, 0);
> >
> > - if (ep) {
> > - ret = of_property_count_u32_elems(ep, "data-lanes");
> > - if (ret == -EINVAL)
> > - /* Property isn't here, consider default mapping */
> > - goto out_done;
> > - if (ret < 0)
> > - goto out_error;
> > -
> > - if (ret != DATA_LANES_COUNT) {
> > - dev_err(&nb7->client->dev, "expected 4 data lanes\n");
> > - ret = -EINVAL;
> > - goto out_error;
> > - }
> > + if (!ep)
> > + return 0;
> > ```
> >
> >
> > Not equivalent code as the out_error:
> >
> > of_node_put(ep);
> >
> > isn't done
> >
> >
>
> Hi joe perches,
>
> If ep is null, I believe we dont need to call of_node_put. Because
> passing null pointer to of_node_put() make no difference.
>
> In of_node_put() definition, if pointer is null, there is no operation.
>

Fine, but you should explain that in the changelog
and not make reviewers look it up.