From: Manu Gautam <mgautam@codeaurora.org>
To: Peter Chen <peter.chen@nxp.com>, mathias.nyman@intel.com
Cc: linux-usb@vger.kernel.org, gregkh@linuxfoundation.org,
linux-imx@nxp.com, Li Jun <jun.li@nxp.com>,
Baolin Wang <baolin.wang@linaro.org>,
Mathias Nyman <mathias.nyman@linux.intel.com>,
stable@vger.kernel.org
Subject: Re: [PATCH 1/1] usb: host: xhci-plat: keep runtime active when remove host
Date: Tue, 12 May 2020 09:19:46 +0530 [thread overview]
Message-ID: <a5ba9001-0371-e675-e013-b8dd4f1c38e2@codeaurora.org> (raw)
In-Reply-To: <20200512023547.31164-1-peter.chen@nxp.com>
Hi,
On 5/12/2020 8:05 AM, Peter Chen wrote:
> Cc: Baolin Wang <baolin.wang@linaro.org>
> Cc: Mathias Nyman <mathias.nyman@linux.intel.com>
> Cc: <stable@vger.kernel.org>
> Fixes: b0c69b4bace3 ("usb: host: plat: Enable xHCI plat runtime PM")
> Reviewed-by: Peter Chen <peter.chen@nxp.com>
> Signed-off-by: Li Jun <jun.li@nxp.com>
> ---
> drivers/usb/host/xhci-plat.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c
> index 1d4f6f85f0fe..f38d53528c96 100644
> --- a/drivers/usb/host/xhci-plat.c
> +++ b/drivers/usb/host/xhci-plat.c
> @@ -362,6 +362,7 @@ static int xhci_plat_remove(struct platform_device *dev)
> struct clk *reg_clk = xhci->reg_clk;
> struct usb_hcd *shared_hcd = xhci->shared_hcd;
>
> + pm_runtime_get_sync(&dev->dev);
Where is corresponding _put() call?
> xhci->xhc_state |= XHCI_STATE_REMOVING;
>
> usb_remove_hcd(shared_hcd);
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2020-05-12 3:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-12 2:35 [PATCH 1/1] usb: host: xhci-plat: keep runtime active when remove host Peter Chen
2020-05-12 3:49 ` Manu Gautam [this message]
2020-05-12 4:03 ` Peter Chen
2020-05-12 22:33 ` Mathias Nyman
2020-05-13 9:14 ` Peter Chen
2020-05-13 14:45 ` 回复: " Jun Li
2020-05-14 1:31 ` Peter Chen
2020-05-14 1:34 ` Alan Stern
2020-05-14 9:06 ` Mathias Nyman
2020-05-14 9:11 ` Peter Chen
2020-05-14 9:18 ` Jun Li
2020-05-12 13:35 ` Alan Stern
2020-05-13 11:08 ` Peter Chen
2020-05-13 14:48 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a5ba9001-0371-e675-e013-b8dd4f1c38e2@codeaurora.org \
--to=mgautam@codeaurora.org \
--cc=baolin.wang@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=jun.li@nxp.com \
--cc=linux-imx@nxp.com \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=mathias.nyman@linux.intel.com \
--cc=peter.chen@nxp.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).