From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF36533A6E9; Wed, 25 Mar 2026 12:24:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.19 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774441490; cv=none; b=sSF4TAy7x3LgKPtaTL9J3wHTApJ/7LF/QW6s6DhW4uyEQPEJwlcwsV4m22gZ/gvG2RsNilGA09DMfXfIxKWVKsyLN/KiK0Q3idhs8NJB+1Mp+CCy0Eq09oen9cHV9gCx6OjqL4i4c4mAa0XjnxjHMy5xN3r/jE4u/B/Gw98SW7I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774441490; c=relaxed/simple; bh=ALWKNvVNm0+2r3Ry2QG32tAeoyhy7TVqmqpTEmbO2Kw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=lj2QSQ1uSAG8R3EJeVOpYTLmLf5Nl/AyFz0ApiYc6B9aXiUgwLvAkBXMI5Cw7HwnPakY+2BkC28Gc8abiehekC7jHTFAL9gXG1CwmV89CEo4b9mV/LEMIojtgyoV11yBXjNHRwcyoBwtJVzOa5mSNGOEmq6JNXsl8o+puZ1psWE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=UcSZK9Oq; arc=none smtp.client-ip=198.175.65.19 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="UcSZK9Oq" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1774441489; x=1805977489; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=ALWKNvVNm0+2r3Ry2QG32tAeoyhy7TVqmqpTEmbO2Kw=; b=UcSZK9Oq5P/FEtsTwqWcmW+WZzr5aNMZiTeDZ99KZloCMJEi+FpM6Whh p7WdEhnmwn5SqT/MREA8JUQ69tb5mAEWxPdeOGpu86SrEJRABG0vh0lwG iqVQmtBLynlXgR+KgXY33ZjMcts2g3X45h1KNixF5TdNGWt55lqOLoVCZ /pvPalMhQ9VTMnI0KhkyqCtKNuHW5kflKbIN0brUIoHqRluyD0uorLSxg uODCdmjmO2sK8FRZi3WUf39gVXfykXsjox9ucZ51kDh0te25XKZKLiqLs 0daNqAS7JS9tFxn28+6HlTc81Aq56sys/V6Ayfe20ACkRno7EncBvHmra w==; X-CSE-ConnectionGUID: S6d3ug8gSbyXnsKanwMpLQ== X-CSE-MsgGUID: 1lwjvAPETQ2Mjj02yXqEzw== X-IronPort-AV: E=McAfee;i="6800,10657,11739"; a="75363446" X-IronPort-AV: E=Sophos;i="6.23,140,1770624000"; d="scan'208";a="75363446" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by orvoesa111.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Mar 2026 05:24:49 -0700 X-CSE-ConnectionGUID: 9BW7yyEAQaKCWYAUnfO/RQ== X-CSE-MsgGUID: fvTQur7XR22g/4FM1CTggA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,140,1770624000"; d="scan'208";a="248184268" Received: from pgcooper-mobl3.ger.corp.intel.com (HELO [10.245.245.106]) ([10.245.245.106]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Mar 2026 05:24:47 -0700 Message-ID: Date: Wed, 25 Mar 2026 14:24:44 +0200 Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] usb: xhci: Fix debugfs bandwidth reporting To: Michal Pecio Cc: Mathias Nyman , Greg Kroah-Hartman , Xu Rao , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260304114928.110be4c4.michal.pecio@gmail.com> <20260325113246.07681667.michal.pecio@gmail.com> Content-Language: en-US From: Mathias Nyman In-Reply-To: <20260325113246.07681667.michal.pecio@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 3/25/26 12:32, Michal Pecio wrote: > On Thu, 19 Mar 2026 23:04:38 +0200, Mathias Nyman wrote: >> On 3/4/26 12:49, Michal Pecio wrote: >>> Replace kernel USB speed numbers with xHCI protocol IDs expected by HW. >>> They are numerically equal up to high speed, but instead of SuperSpeed >>> we were querying SuperSpeed+. >>> >>> Gen1 hardware rejects such commands with TRB Error, which resulted in >>> zero available bandwidth being shown. >>> >>> While at that, report command failure as IO error, not zero bandwidth. >>> >>> Signed-off-by: Michal Pecio >> >> Added to queue > > Hi, > > Thanks for taking the patch, but can we have a last minute swap for > a v2 or optionally v3? > Sure, no problem. > Problem is that returning -EIO is common (the command is optional) > and it upsets userspace: "grep -r" spams the console with errors, > "zip -R" terminates and doesn't include remaining files, etc. > So I would prefer to print an error string in this case. > "Real" errors will still be returned ordinarily. > > The optional v3 also renames the new directory for consistency. > Technically it's a breaking change, but I believe it's permissible > in debugfs, particularly for an interface only added recently. > lets stick with v2, avoiding possible breakage due to debugfs file rename. Thanks Mathias