Re: [PATCH 2/2] scsi: core: Do not query IO hints for USB devices

[Bart Van Assche <bvanassche@acm.org>]

On 6/12/24 11:08 AM, Alan Stern wrote:
> You might want to do the same thing in uas.c.  I don't know if UAS
> devices suffer from the same problem, but it wouldn't be surprising if
> they do.

Hi Alan,

How about replacing patch 2/2 from this series with the patch below?

Thanks,

Bart.

diff --git a/drivers/usb/storage/scsiglue.c b/drivers/usb/storage/scsiglue.c
index b31464740f6c..b4cf0349fd0d 100644
--- a/drivers/usb/storage/scsiglue.c
+++ b/drivers/usb/storage/scsiglue.c
@@ -79,6 +79,12 @@ static int slave_alloc (struct scsi_device *sdev)
  	if (us->protocol == USB_PR_BULK && us->max_lun > 0)
  		sdev->sdev_bflags |= BLIST_FORCELUN;

+	/*
+	 * Some USB storage devices reset if the IO hints VPD page is queried.
+	 * Hence skip that VPD page.
+	 */
+	sdev->sdev_bflags |= BLIST_SKIP_IO_HINTS;
+
  	return 0;
  }

diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c
index a48870a87a29..bb75901b53e3 100644
--- a/drivers/usb/storage/uas.c
+++ b/drivers/usb/storage/uas.c
@@ -820,6 +820,12 @@ static int uas_slave_alloc(struct scsi_device *sdev)
  	struct uas_dev_info *devinfo =
  		(struct uas_dev_info *)sdev->host->hostdata;

+	/*
+	 * Some USB storage devices reset if the IO hints VPD page is queried.
+	 * Hence skip that VPD page.
+	 */
+	sdev->sdev_bflags |= BLIST_SKIP_IO_HINTS;
+
  	sdev->hostdata = devinfo;
  	return 0;
  }