From: Mats Karrman <mats.dev.list@gmail.com>
To: Peter Chen <peter.chen@nxp.com>, linux-usb@vger.kernel.org
Cc: linux-imx@nxp.com,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Subject: [1/1] usb: chipidea: host: fix disconnection detect issue
Date: Wed, 6 Jun 2018 09:27:33 +0200 [thread overview]
Message-ID: <a7b629ff-e7f7-e655-9432-03afe7dad0b9@gmail.com> (raw)
On 2018-06-06 04:04, Peter Chen wrote:
> The commit 4e88d4c08301 ("usb: add a flag to skip PHY
> initialization to struct usb_hcd") delete the assignment
> for hcd->usb_phy, it causes usb_phy_notify_connect{disconnect)
> are not called, the USB PHY driver is not notified of hot plug
> event, then the disconnection will not be detected by hardware.
>
> Fixes: 4e88d4c08301 ("usb: add a flag to skip PHY initialization
> to struct usb_hcd")
> Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> Reported-by: Mats Karrman <mats.dev.list@gmail.com>
> Signed-off-by: Peter Chen <peter.chen@nxp.com>
Works for me!
Tested on SolidRun Hummingboard fsl,imx6dl
Tested-by: Mats Karrman <mats.dev.list@gmail.com>
Thanks,
Mats
> ---
> drivers/usb/chipidea/host.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/chipidea/host.c b/drivers/usb/chipidea/host.c
> index af45aa3222b5..4638d9b066be 100644
> --- a/drivers/usb/chipidea/host.c
> +++ b/drivers/usb/chipidea/host.c
> @@ -124,8 +124,11 @@ static int host_start(struct ci_hdrc *ci)
>
> hcd->power_budget = ci->platdata->power_budget;
> hcd->tpl_support = ci->platdata->tpl_support;
> - if (ci->phy || ci->usb_phy)
> + if (ci->phy || ci->usb_phy) {
> hcd->skip_phy_initialization = 1;
> + if (ci->usb_phy)
> + hcd->usb_phy = ci->usb_phy;
> + }
>
> ehci = hcd_to_ehci(hcd);
> ehci->caps = ci->hw_bank.cap;
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next reply other threads:[~2018-06-06 7:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-06 7:27 Mats Karrman [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-06-06 19:54 [1/1] usb: chipidea: host: fix disconnection detect issue Martin Blumenstingl
2018-06-06 2:04 Peter Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a7b629ff-e7f7-e655-9432-03afe7dad0b9@gmail.com \
--to=mats.dev.list@gmail.com \
--cc=linux-imx@nxp.com \
--cc=linux-usb@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=peter.chen@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).