From: Mario Limonciello <superm1@kernel.org>
To: Kenneth Crudup <kenny@panix.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: mario.limonciello@amd.com, andreas.noever@gmail.com,
westeri@kernel.org, YehezkelShB@gmail.com, Sanath.S@amd.com,
linux-usb@vger.kernel.org
Subject: Re: [PATCH] thunderbolt: Reset NHI during S4 restore_noirq() callback
Date: Tue, 4 Nov 2025 15:21:46 -0600 [thread overview]
Message-ID: <a849fe60-4dab-428f-a97b-932d597dfc88@kernel.org> (raw)
In-Reply-To: <3aa6006d-450c-4253-a617-bd76114e9ede@panix.com>
On 11/4/25 3:19 PM, Kenneth Crudup wrote:
>
> On 11/4/25 12:31, Mario Limonciello wrote:
>
>> Are you doing S4 at all? Or only s2idle/s3? The patch was
>> specifically for resume from S4.
>
> Ah, good point and I'll have to look out for that, but I do use "hybrid
> sleep", which (AIUI) starts a hibernation cycle but stays (in my case)
> in s0ix suspend until after 4h have passed.
>
> -K
>
The behavior you describe is suspend-then-hibernate not hybrid sleep.
Could you confirm which one you're using?
This patch could change suspend-then-hibernate (if you resumed from
hibernate not suspend) but hybrid sleep would only help if the system
lost power during suspend (like a dead battery).
For the purposes of testing this patch works it's probably easiest to do
pure S4.
next prev parent reply other threads:[~2025-11-04 21:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-23 5:03 [PATCH] thunderbolt: Reset NHI during S4 restore_noirq() callback Mario Limonciello (AMD)
2025-10-23 5:56 ` Mika Westerberg
2025-10-23 14:13 ` Mario Limonciello
2025-11-04 19:11 ` Kenneth Crudup
2025-11-04 19:12 ` Mario Limonciello
2025-11-04 20:22 ` Kenneth Crudup
2025-11-04 20:31 ` Mario Limonciello
2025-11-04 21:19 ` Kenneth Crudup
2025-11-04 21:21 ` Mario Limonciello [this message]
2025-11-05 19:06 ` Kenneth Crudup
2025-11-05 19:16 ` Mario Limonciello (AMD) (kernel.org)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a849fe60-4dab-428f-a97b-932d597dfc88@kernel.org \
--to=superm1@kernel.org \
--cc=Sanath.S@amd.com \
--cc=YehezkelShB@gmail.com \
--cc=andreas.noever@gmail.com \
--cc=kenny@panix.com \
--cc=linux-usb@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=mika.westerberg@linux.intel.com \
--cc=westeri@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).