From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 300691E87B for ; Sat, 25 Jan 2025 13:01:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737810121; cv=none; b=ApnNQOhPSAP0aXu1F1zjm900+IaaAy5LBoY1AFrEgpukn9FiKCcCLCo5CDic4x0z5yY9amMxQ6MlnKmrHoYUUoIDuPJQKRpBPQBxs3AfftFCO6cCzMN1QErdHWRq8TX16g4OWIQc3ois1/ST/1YQkGqP5wcgCDC3GAkPF8z0T9E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737810121; c=relaxed/simple; bh=sS3mbLcH/a5SluKPTNpMDj9ztVNCWo8wMrmAJjvAAd0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=D04qIwkV5eJFdZkCdnoIrqF3WoB0ME5wcZfqtdGt8kLMA8u/aYmwdJir7Ruk3W0WsOm/lk1WuvHBrqHNkvVapXr/gcL+JEJW7h7f7PokWYvFQg873urNY308sQJ/nh6DQeJg6StyXm3Ypx2YFSGZu9818p5MCy2dHf0pjKDdAiE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=H6qeFs9p; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="H6qeFs9p" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-38a34e8410bso1547397f8f.2 for ; Sat, 25 Jan 2025 05:01:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1737810117; x=1738414917; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=xBwEaJIA2+RPZbUWu+2aJuzA7zzqm1Ht0aJnI9t2LyA=; b=H6qeFs9pqBK9iMZi8kUOJdlr09AdpyWHp/GzAQuLgpwhossZAxNw9O8UU9HvclrrMz eqxlcod+7cFWwbc4Yh3UEI5MmHYrdw9NfEXO4gYUGf7/eMh9K9p2TjUJodSKZnWndwW/ v6Ill/iaeoMKvlBuscWJUXu6mxbi+qOULPRakGodSXhjC3xSo/2cKBZzYdUYlYjp/i6L +WdF3TB3QwhtVOx5Sq5mNYKcWwaVtpbCAbtRXoovMrmaFzp9F0kmQJG7VIgMxaO+J54/ jc+Ts6kPJMuBDJyzFaZo5djxuOPzeZ3T3PfJ1ZAr6LY2i5/tnurPxHd9YG+3L747efbt okbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737810117; x=1738414917; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=xBwEaJIA2+RPZbUWu+2aJuzA7zzqm1Ht0aJnI9t2LyA=; b=n+nEDRlloG8DG1f0BKE1AT1spYXAeCfH4vgq6Z1SjlmGJzF/K29U0c+YyJMSEIZJBg 4Yg2lV7fFisvgTL3HU6ofRBTxRdG0jf2eBQnABjo5Vnyfi+YyKQbiZV57LImp+3nCgWO KwJgAKkHRMZmEHpmqxPDawIwwHxkJGGnYpAVWt+2+Y2DNNw3m1lb2W+uRUYyVCkGAYMg 0o2rIfpAKpTSE7aK+IWnz2tWBVnNJ9arI989E6FRSmDwwchuHro0HS45CnmJ1x528oHI 7Ra+vNeuPawn6Gdo9EMmmWrRJvXJBCeAaK/qCR0V9CaxQrizyFsL/LB2ykNTvtvMG1G8 hvjQ== X-Forwarded-Encrypted: i=1; AJvYcCWx/5b6eMNQugmzvh1Z29hrn+upKGVYRFW6N3+vjQbkbcfRs1HocayfN/V9DI2iQ0nDNA2Qcd+FTi8=@vger.kernel.org X-Gm-Message-State: AOJu0YxCcqgQlq9HDtaVCiVlEJX5IOZVov+9vZ9ZQnk47mT1OGNtAKMr nOEGus65q9zpvLYoI4FZxEWxeJ7dkXxbrAEzWYsRhvDM4fur5aav6R0E+9uSoj0= X-Gm-Gg: ASbGnct2CUUB2KzXPICrBgOXz+yhpP3mBRl3qB00mfydxra6GvLjX175d2/wO2MGMoO V/yREnTGsbCz0eNqXTZc92xvbaIDjdP7Hc2RmLjPG0uIK35lmjFIjfmX7MhjfOo4Bk3hI1F2yjn KSlKMDiKV54heMf9urU2BNJv8LQa+70/tl8/a+VED6f1xP9LgZux1B3YZBuHM+ZfQGU31We6qrd fsqNQhqSsTTG8DEGkcgJOlGXEdl5NLaH++v7g1PRhVtZTZlW5VDucmbC2QtjWMZ8oCBhKDwVCjQ spUvk38dcQ== X-Google-Smtp-Source: AGHT+IHir8pG3ke37S38Jlyrqg7Fse028mZg7kRs2RqqnJe7pIok9pvHY4SBG300epRnjxxv/2Kdyw== X-Received: by 2002:a05:6000:1acc:b0:386:4a16:dad7 with SMTP id ffacd0b85a97d-38bf566e605mr31944238f8f.10.1737810116885; Sat, 25 Jan 2025 05:01:56 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38c2a17d315sm5506679f8f.22.2025.01.25.05.01.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Jan 2025 05:01:56 -0800 (PST) Date: Sat, 25 Jan 2025 16:01:52 +0300 From: Dan Carpenter To: Benson Leung Cc: Heikki Krogerus , linux-usb@vger.kernel.org, abhishekpandit@chromium.org, ukaszb@chromium.org, akuchynski@google.com, bleung@chromium.org Subject: Re: [bug report] usb: typec: Add driver for Thunderbolt 3 Alternate Mode Message-ID: References: <48dbbbab-3d09-4162-9d76-74c9baca6603@stanley.mountain> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, Jan 24, 2025 at 07:56:38PM +0000, Benson Leung wrote: > Hi Dan, > > > On Tue, Jan 07, 2025 at 05:16:43PM +0300, Dan Carpenter wrote: > > Hello Heikki Krogerus, > > > > Commit 100e25738659 ("usb: typec: Add driver for Thunderbolt 3 > > Alternate Mode") from Dec 13, 2024 (linux-next), leads to the > > following (unpublished) Smatch static checker warnings: > > > > drivers/usb/typec/altmodes/thunderbolt.c:153 tbt_enter_modes_ordered() info: return a literal instead of 'ret' > > I posted a couple of patches to fix the other warnings, but wasn't sure what to > with this one since by my reading, we're doing that intentionally. This seems > like an informational message. Fine fine. It's an unpublished warning. regards, dan carpenter