Linux USB
 help / color / mirror / Atom feed
From: Ze Huang <huangze@whut.edu.cn>
To: Yixun Lan <dlan@gentoo.org>, Ze Huang <huangze@whut.edu.cn>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Alexandre Ghiti <alex@ghiti.fr>,
	linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
	linux-riscv@lists.infradead.org, spacemit@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 3/4] usb: dwc3: add generic driver to support flattened DT
Date: Fri, 6 Jun 2025 19:43:38 +0800	[thread overview]
Message-ID: <aELUajmfzmb7w3W9@jean.localdomain> (raw)
In-Reply-To: <20250605213443.17a7aa26b@smtp.qiye.163.com>

On Thu, Jun 05, 2025 at 01:34:27PM +0000, Yixun Lan wrote:
> Hi Ze,
> 
> On 22:40 Mon 26 May     , Ze Huang wrote:
> > To support flattened dwc3 dt model and drop the glue layer, introduce the
> > `dwc3-generic` driver. This enables direct binding of the DWC3 core driver
> > and offers an alternative to the existing glue driver `dwc3-of-simple`.
> > 
> > Signed-off-by: Ze Huang <huangze@whut.edu.cn>
> > ---
...
> > +	ret = reset_control_deassert(dwc3->resets);
> > +	if (ret) {
> > +		dev_err(dev, "failed to deassert reset\n");
> > +		goto reset_assert;
> > +	}
> > +
> > +	ret = clk_bulk_get_all(dwc3->dev, &dwc3->clks);
> can you check if able to use devres api for reset/clock here?
> (functions start devm_ prefix)
> 

OK, will do

  parent reply	other threads:[~2025-06-06 11:43 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-26 14:40 [PATCH v4 0/4] Add SpacemiT K1 USB3.0 host controller support Ze Huang
2025-05-26 14:40 ` [PATCH v4 1/4] dt-bindings: usb: dwc3: add support for SpacemiT K1 Ze Huang
2025-05-27  6:47   ` Krzysztof Kozlowski
2025-05-27  6:53   ` Krzysztof Kozlowski
2025-05-26 14:40 ` [PATCH v4 2/4] dt-bindings: soc: spacemit: Add K1 MBUS controller Ze Huang
2025-05-27  6:51   ` Krzysztof Kozlowski
2025-05-27 11:13     ` Ze Huang
2025-05-27 16:25       ` Rob Herring
2025-05-27 16:41         ` Ze Huang
2025-05-27 17:12           ` Rob Herring
2025-05-27  6:54   ` Krzysztof Kozlowski
2025-05-27 11:15     ` Ze Huang
2025-05-26 14:40 ` [PATCH v4 3/4] usb: dwc3: add generic driver to support flattened DT Ze Huang
2025-06-03  1:20   ` Thinh Nguyen
2025-06-03  2:51     ` Ze Huang
2025-07-04  2:10       ` Frank Li
2025-07-04  2:41         ` Ze Huang
2025-06-05 13:34   ` Yixun Lan
     [not found]   ` <20250605213443.17a7aa26b@smtp.qiye.163.com>
2025-06-06 11:43     ` Ze Huang [this message]
2025-05-26 14:40 ` [PATCH v4 4/4] riscv: dts: spacemit: add usb3.0 support for K1 Ze Huang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aELUajmfzmb7w3W9@jean.localdomain \
    --to=huangze@whut.edu.cn \
    --cc=Thinh.Nguyen@synopsys.com \
    --cc=alex@ghiti.fr \
    --cc=aou@eecs.berkeley.edu \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlan@gentoo.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=robh@kernel.org \
    --cc=spacemit@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox