From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Tomasz Michalec <tmichalec@google.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Konrad Adamczyk <konrada@google.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
chromeos-krk-upstreaming@google.com
Subject: Re: [PATCH] usb: typec: intel_pmc_mux: Defer probe if SCU IPC isn't present
Date: Wed, 11 Jun 2025 13:21:16 +0300 [thread overview]
Message-ID: <aElYnJOpoGbrg-6u@kuha.fi.intel.com> (raw)
In-Reply-To: <20250610154058.1859812-1-tmichalec@google.com>
On Tue, Jun 10, 2025 at 05:40:58PM +0200, Tomasz Michalec wrote:
> If pmc_usb_probe is called before SCU IPC is registered, pmc_usb_probe
> will fail.
>
> Return -EPROBE_DEFER when pmc_usb_probe doesn't get SCU IPC device, so
> the probe function can be called again after SCU IPC is initialized.
>
> Signed-off-by: Tomasz Michalec <tmichalec@google.com>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> drivers/usb/typec/mux/intel_pmc_mux.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/typec/mux/intel_pmc_mux.c b/drivers/usb/typec/mux/intel_pmc_mux.c
> index 65dda9183e6f..1698428654ab 100644
> --- a/drivers/usb/typec/mux/intel_pmc_mux.c
> +++ b/drivers/usb/typec/mux/intel_pmc_mux.c
> @@ -754,7 +754,7 @@ static int pmc_usb_probe(struct platform_device *pdev)
>
> pmc->ipc = devm_intel_scu_ipc_dev_get(&pdev->dev);
> if (!pmc->ipc)
> - return -ENODEV;
> + return -EPROBE_DEFER;
>
> pmc->dev = &pdev->dev;
>
> --
> 2.50.0.rc0.604.gd4ff7b7c86-goog
--
heikki
prev parent reply other threads:[~2025-06-11 10:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-10 15:40 [PATCH] usb: typec: intel_pmc_mux: Defer probe if SCU IPC isn't present Tomasz Michalec
2025-06-11 10:21 ` Heikki Krogerus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aElYnJOpoGbrg-6u@kuha.fi.intel.com \
--to=heikki.krogerus@linux.intel.com \
--cc=chromeos-krk-upstreaming@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=konrada@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=tmichalec@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox