From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: a0282524688@gmail.com
Cc: tmyu0@nuvoton.com, lee@kernel.org, linus.walleij@linaro.org,
brgl@bgdev.pl, andi.shyti@kernel.org, mkl@pengutronix.de,
mailhol.vincent@wanadoo.fr, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, wim@linux-watchdog.org, linux@roeck-us.net,
jdelvare@suse.com, alexandre.belloni@bootlin.com,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-i2c@vger.kernel.org, linux-can@vger.kernel.org,
netdev@vger.kernel.org, linux-watchdog@vger.kernel.org,
linux-hwmon@vger.kernel.org, linux-rtc@vger.kernel.org,
linux-usb@vger.kernel.org
Subject: Re: [PATCH v13 3/7] i2c: Add Nuvoton NCT6694 I2C support
Date: Mon, 14 Jul 2025 09:37:32 +0200 [thread overview]
Message-ID: <aHSzvBYwYUpQTAQr@shikoro> (raw)
In-Reply-To: <20250627102730.71222-4-a0282524688@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 306 bytes --]
> + if (msg_temp->len > 64)
> + return -EPROTO;
Please populate and use 'struct i2c_adapter_quirks' so the I2C core can
handle the checks for you. At least max_read_len and max_write_len. But
please also do check the other flags. Usually, USB adapters have way
more limitations than the buffer size.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2025-07-14 7:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-27 10:27 [PATCH v13 0/7] Add Nuvoton NCT6694 MFD drivers a0282524688
2025-06-27 10:27 ` [PATCH v13 1/7] mfd: Add core driver for Nuvoton NCT6694 a0282524688
2025-06-28 12:30 ` Markus Elfring
2025-07-02 16:15 ` Lee Jones
2025-07-03 2:39 ` Ming Yu
2025-07-03 2:44 ` Vincent Mailhol
2025-07-07 10:07 ` Marc Kleine-Budde
2025-06-27 10:27 ` [PATCH v13 2/7] gpio: Add Nuvoton NCT6694 GPIO support a0282524688
2025-06-27 10:27 ` [PATCH v13 3/7] i2c: Add Nuvoton NCT6694 I2C support a0282524688
2025-07-14 7:37 ` Wolfram Sang [this message]
2025-06-27 10:27 ` [PATCH v13 4/7] can: Add Nuvoton NCT6694 CANFD support a0282524688
2025-06-27 10:27 ` [PATCH v13 5/7] watchdog: Add Nuvoton NCT6694 WDT support a0282524688
2025-07-02 22:16 ` Guenter Roeck
2025-06-27 10:27 ` [PATCH v13 6/7] hwmon: Add Nuvoton NCT6694 HWMON support a0282524688
2025-06-27 10:27 ` [PATCH v13 7/7] rtc: Add Nuvoton NCT6694 RTC support a0282524688
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aHSzvBYwYUpQTAQr@shikoro \
--to=wsa+renesas@sang-engineering.com \
--cc=a0282524688@gmail.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andi.shyti@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=brgl@bgdev.pl \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jdelvare@suse.com \
--cc=kuba@kernel.org \
--cc=lee@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mailhol.vincent@wanadoo.fr \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=tmyu0@nuvoton.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox