From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org, Zijun Hu <quic_zijuhu@quicinc.com>,
Oliver Neukum <oneukum@suse.com>,
Alan Stern <stern@rowland.harvard.edu>
Subject: Re: [PATCH 1/1] USB: Check no positive return values from pm_runtime_resume_and_get()
Date: Fri, 15 Aug 2025 09:34:00 +0000 [thread overview]
Message-ID: <aJ7_CMzCVwPEMSOj@kekkonen.localdomain> (raw)
In-Reply-To: <2025081330-droplet-napping-6843@gregkh>
Hi Greg,
On Wed, Aug 13, 2025 at 04:43:05PM +0200, Greg Kroah-Hartman wrote:
> On Mon, Aug 11, 2025 at 09:24:03AM +0300, Sakari Ailus wrote:
> > pm_runtime_resume_and_get() always returns a negative error code or zero;
> > there's no need to check for positive values such as returned by
> > pm_runtime_get_sync(). Simply drop the check.
> >
> > Fixes: 7626c52b6b46 ("usb: usb_autopm_get_interface use modern helper")
> > Cc: stable@vger.kernel.org
>
> If there is no need for this check, why does this need to be backported
> to stable kernels?
It's not necessary IMO.
The practice lately has been to add Cc: stable if the Fixes: tag is there.
But there was no actual bug in this case, just that this change ideally
would have been part of the original patch.
--
Regards,
Sakari Ailus
next prev parent reply other threads:[~2025-08-15 9:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-11 6:24 [PATCH 1/1] USB: Check no positive return values from pm_runtime_resume_and_get() Sakari Ailus
2025-08-13 14:43 ` Greg Kroah-Hartman
2025-08-15 9:34 ` Sakari Ailus [this message]
2025-08-15 9:38 ` Greg Kroah-Hartman
2025-08-15 10:06 ` Sakari Ailus
2025-08-15 10:14 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aJ7_CMzCVwPEMSOj@kekkonen.localdomain \
--to=sakari.ailus@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=oneukum@suse.com \
--cc=quic_zijuhu@quicinc.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).