From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB120246BD5; Fri, 8 Aug 2025 07:22:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754637758; cv=none; b=TZ8NvZWe1Kxu4EXDyE9Gd4/6pROkttzRui8rixWHbzN27qMrCT5txs0XGM0nH/22BKTjgpMqUBwQbNMZIULY51jTgazetZOArt/yQZyCuFof7Z3UX7fnJgZYB7guzFkWXQhYOTEr7xHHRFEOPOcUG5uYlumTqDDcRgDnv9O+N3k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754637758; c=relaxed/simple; bh=fbLBorPezoJWXQtvSg4WV87SLfHofuZpGSIX8FwjR+A=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=m8iyTx+7cEmRwcWupZmd1iQd1/LY0ZnfAJzoNhSVHEAG9k4frHlZ/miICFejPsBXEHQU5n+gOuH5/bJpDlk7/616LKLXAHyzhXmDPUIJYyF68ZhKLHhba2l5I7l/oeHH/EH0sB6dU9TDzvFdl0L+8Fp7ilS42KVBCejA3su8fGA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=LZyDbp83; arc=none smtp.client-ip=192.198.163.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="LZyDbp83" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1754637757; x=1786173757; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=fbLBorPezoJWXQtvSg4WV87SLfHofuZpGSIX8FwjR+A=; b=LZyDbp8308W23nZhpDlqnPjcGKLTspL+l+YQGjiQtSTzpSI1Jwf5izRT 7Z+2zhqAkpxQL/dBOw8ncfU/0NHe1ypIjOHAKSGB7kcor5vxrbbMSdRHW 2hYqvDyapji4PCy67PeuNCcSC0H/Rqu8DyUIj7zwbhkdaroHx65hkj5tl St3e2d9n44sKj/YtQOE474jD/OlVohvj49A4b+2p3MuD7hb48IhpFF65c oHf7nayLb0ZsXKOQcPFhNMMiwkCSqGLq2MFumKQTQ/HT75DbKwHHy8jS8 XCbDKaKKpkgYVZDSNeczb7FOIrH1bfkoPPOq5cx9UIIHhweRymtQBEx9Y w==; X-CSE-ConnectionGUID: h3mAh/WWRtKeNa4tONUVaQ== X-CSE-MsgGUID: Htes8MdmRfCzJy/5itKGOg== X-IronPort-AV: E=McAfee;i="6800,10657,11514"; a="82427431" X-IronPort-AV: E=Sophos;i="6.17,274,1747724400"; d="scan'208";a="82427431" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Aug 2025 00:22:35 -0700 X-CSE-ConnectionGUID: /7IVcpDgQ9qpoWqkKm2wXg== X-CSE-MsgGUID: iyK3MnEqR96jQ4z4ReFADA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.17,274,1747724400"; d="scan'208";a="188944169" Received: from fpallare-mobl4.ger.corp.intel.com (HELO kekkonen.fi.intel.com) ([10.245.245.151]) by fmviesa002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Aug 2025 00:22:33 -0700 Received: from kekkonen.localdomain (localhost [127.0.0.1]) by kekkonen.fi.intel.com (Postfix) with SMTP id 7FB8211FC97; Fri, 8 Aug 2025 10:22:31 +0300 (EEST) Date: Fri, 8 Aug 2025 07:22:31 +0000 Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo From: Sakari Ailus To: Laurent Pinchart Cc: Jacopo Mondi , Mauro Carvalho Chehab , Devarsh Thakkar , Benoit Parrot , Hans Verkuil , Mike Isely , Hans de Goede , Parthiban Veerasooran , Christian Gromm , Greg Kroah-Hartman , Alex Shi , Yanteng Si , Dongliang Mu , Jonathan Corbet , Tomasz Figa , Marek Szyprowski , Andy Walls , Michael Tretter , Pengutronix Kernel Team , Bin Liu , Matthias Brugger , AngeloGioacchino Del Regno , Dmitry Osipenko , Thierry Reding , Jonathan Hunter , Mirela Rabulea , Shawn Guo , Sascha Hauer , Fabio Estevam , Kieran Bingham , Michal Simek , Ming Qian , Zhou Peng , Xavier Roumegue , Philipp Zabel , Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Sylwester Nawrocki , Jernej Skrabec , Chen-Yu Tsai , Samuel Holland , Daniel Almeida , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Nas Chung , Jackson Lee , Minghsiu Tsai , Houlong Wei , Andrew-CT Chen , Tiffany Lin , Yunfei Dong , Geert Uytterhoeven , Magnus Damm , Mikhail Ulyanov , Jacob Chen , Ezequiel Garcia , Heiko Stuebner , Detlev Casanova , Krzysztof Kozlowski , Alim Akhtar , Sylwester Nawrocki , =?utf-8?Q?=C5=81ukasz?= Stelmach , Andrzej Pietrasiewicz , Jacek Anaszewski , Andrzej Hajda , Fabien Dessenne , Hugues Fruchet , Jean-Christophe Trotin , Maxime Coquelin , Alexandre Torgue , Nicolas Dufresne , Benjamin Gaignard , Steve Longerbeam , Maxime Ripard , Paul Kocialkowski , Niklas =?iso-8859-1?Q?S=F6derlund?= , Robert Foss , Todor Tomov , Vladimir Zapolskiy , Corentin Labbe , Bingbu Cao , Tianshu Qiu , Stanislaw Gruszka , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-tegra@vger.kernel.org, imx@lists.linux.dev, linux-renesas-soc@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-sunxi@lists.linux.dev, linux-usb@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, mjpeg-users@lists.sourceforge.net Subject: Re: [PATCH 64/65] media: staging: ipu7: isys: Don't set V4L2_FL_USES_V4L2_FH manually Message-ID: References: <20250802-media-private-data-v1-0-eb140ddd6a9d@ideasonboard.com> <20250802-media-private-data-v1-64-eb140ddd6a9d@ideasonboard.com> <20250807170135.GH11583@pendragon.ideasonboard.com> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250807170135.GH11583@pendragon.ideasonboard.com> On Thu, Aug 07, 2025 at 08:01:35PM +0300, Laurent Pinchart wrote: > Hi Sakari, > > On Thu, Aug 07, 2025 at 09:07:13AM +0000, Sakari Ailus wrote: > > On Sat, Aug 02, 2025 at 11:23:26AM +0200, Jacopo Mondi wrote: > > > From: Laurent Pinchart > > > > > > The V4L2_FL_USES_V4L2_FH flag is set by v4l2_fh_init(). It is not meant > > > to be set manually by drivers. Drop it from the ipu7-isys driver. > > > > > > Signed-off-by: Laurent Pinchart > > > Signed-off-by: Jacopo Mondi > > > > Thanks, Jacopo! > > > > Reviewed-by: Sakari Ailus > > Can we get you review on patch 63/65 too (for the IPU6 driver) too ? Done. -- Sakari Ailus